[release-4.17] OCPBUGS-63460: UPSTREAM: <carry>: backporting fix for concurrent map iteration and write #2456 #2496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d write Improve audit context handling by encapsulating event data and operations behind a structured API. Make the Audit system more robust in concurrent environments by properly isolating mutable state. The cleaner API simplifies interaction with audit events, improving maintainability. Encapsulation reduces bugs by preventing direct manipulation of audit events. Signed-off-by: Davanum Srinivas <[email protected]> Co-Authored-By: Jordan Liggitt <[email protected]> Co-Authored-By: sxllwx <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]> Co-Authored-By: Jordan Liggitt <[email protected]> Co-Authored-By: Thomas Jungblut <[email protected]> Set event level during context init, fixing imports Signed-off-by: Davanum Srinivas <[email protected]> Signed-off-by: Thomas Jungblut <[email protected]>
… going to use it Merge pull request kubernetes#131725 from dims/avoid-encoding-in-log-response-object-when-we-dont-need-it
When backporting some changes from upstream's master branch a unit test ended up being broken. The code covered by this test does not seem to exist upstream, neither the test file. The code this commit fixes was introduced by 57c60d8 and we should squash this one with it once the time for rebasing arrives. Even though 57c60d8 description reads "UPSTREAM: 115328: annotate early and late requests" the upstream PR 115328 was closed without merging.
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-61773 has been cloned as Jira Issue OCPBUGS-63460. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-63460, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@bertinatto Fabio, could you please use your magic approval for this branch? This unfortunately needs to go to 4.16 |
|
/jira refresh |
|
@tjungblu: This pull request references Jira Issue OCPBUGS-63460, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @bertinatto |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mrobson: This pull request references Jira Issue OCPBUGS-63460, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Sorry, I missed this. /lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
duanwei33,
gangwgr,
kasturinarra,
lyman9966,
wangke19,
xingxingxia and
zhouying7780
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
removed
the
backports/unvalidated-commits
|
/verified by @wangke19 The above test log shows TestAuditBackendRaceCondition is passing but is extremely slow, with each sub-test taking about 30 seconds. This points to a timeout being hit repeatedly, which suggests a performance regression in the audit webhook backend, likely introduced by the backported changes mentioned in the commit message. The current commit fixes a broken test due to the backport but does not address the underlying performance problem. To understand the cause of the slowdown, we need to examine the implementation of Analyzed TestAuditBackendRaceCondition and found it's designed to run for 30 seconds per backend, matching the wait.ForeverTestTimeout value. The slowness isn't a bug, but a test characteristic. Conclusion: The TestAuditBackendRaceCondition test's slowness is by design, using a 30-second timeout. It's not a bug, but an inefficient test. The webhook delays are likely due to rate-limiting from high-frequency requests. The last commit is unrelated. |
openshift-ci-robot
added
the
verified
|
@wangke19: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit ac453ed
into
openshift:release-4.17
18 checks passed
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-63460 Jira Issue OCPBUGS-63460 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: #2496 failed to apply on top of branch "release-4.16": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in accepted release 4.17.0-0.nightly-2025-10-28-172133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2475
/assign tjungblu
/cherrypick release-4.16