Skip to content

CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes #9945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes #9945

wants to merge 1 commit into from

Conversation

@jhixson74
Copy link
Member

@jhixson74 jhixson74 commented Sep 17, 2025 •
edited
Loading

GP3 volumes have the ability to configure throughput from 125 MiB/s to 1000 MiB/s. This allows the ability to set this at install time in the install-config.

https://issues.redhat.com/browse/CORS-4212
https://issues.redhat.com/browse/CORS-4213
https://issues.redhat.com/browse/CORS-4214
https://issues.redhat.com/browse/CORS-4277

This depends on openshift/api#2480 and openshift/machine-api-provider-aws#155

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2025 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-4212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

In response to this:

GP3 volumes have the ability to configure throughput from 125 MiB/s to 1000 MiB/s. This allows the ability to set this at install time in the install-config.

https://issues.redhat.com/browse/CORS-4212
https://issues.redhat.com/browse/CORS-4213
https://issues.redhat.com/browse/CORS-4214

This depends on openshift/api#2480

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhixson74
Copy link
Member Author

jhixson74 commented Sep 17, 2025

/label do-not-merge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

@jhixson74: The label(s) /label do-not-merge cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label do-not-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhixson74
Copy link
Member Author

jhixson74 commented Sep 17, 2025

/label do-not-merge/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

@jhixson74: The label(s) /label do-not-merge/hold cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label do-not-merge/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhixson74
Copy link
Member Author

jhixson74 commented Sep 17, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2025
@tthvo
Copy link
Member

tthvo commented Sep 17, 2025

/cc

@openshift-ci openshift-ci bot requested a review from tthvo September 17, 2025 17:07
patrickdillon
patrickdillon approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me

/approve

There are a few small things that should be cleaned up, commented below. And there is no rush because this depends on openshift/api#4212

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
mtulio
mtulio reviewed Sep 24, 2025
View reviewed changes
@jhixson74 jhixson74 force-pushed the main_aws_gp3_throughput branch 2 times, most recently from c34bb47 to 0768ab9 Compare October 29, 2025 16:50
@jhixson74
AWS: Add the ability to configure throughput on GP3 volumes
d6c4527 
GP3 volumes have the ability to configure throughput from 125 MiB/s to
1000 MiB/s. This allows the ability to set this at install time in the
install-config.

https://issues.redhat.com/browse/CORS-4212
@jhixson74 jhixson74 force-pushed the main_aws_gp3_throughput branch from 0768ab9 to d6c4527 Compare October 29, 2025 18:33
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-4212 which is a valid jira issue.

In response to this:

GP3 volumes have the ability to configure throughput from 125 MiB/s to 1000 MiB/s. This allows the ability to set this at install time in the install-config.

https://issues.redhat.com/browse/CORS-4212
https://issues.redhat.com/browse/CORS-4213
https://issues.redhat.com/browse/CORS-4214
https://issues.redhat.com/browse/CORS-4277

This depends on openshift/api#2480 and openshift/machine-api-provider-aws#155

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-externallb-ovn 6409103 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-azure-ovn-resourcegroup 6409103 link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-aws-custom-dns-techpreview 6409103 link false /test e2e-aws-custom-dns-techpreview
ci/prow/e2e-vsphere-ovn-multi-network 6409103 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-vsphere-static-ovn 6409103 link false /test e2e-vsphere-static-ovn
ci/prow/okd-scos-images d6c4527 link true /test okd-scos-images
ci/prow/e2e-aws-ovn-fips d6c4527 link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-byo-subnet-role-security-groups d6c4527 link false /test e2e-aws-byo-subnet-role-security-groups
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation d6c4527 link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/e2e-aws-default-config d6c4527 link false /test e2e-aws-default-config
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones d6c4527 link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/govet d6c4527 link true /test govet
ci/prow/okd-scos-e2e-aws-ovn d6c4527 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups d6c4527 link false /test e2e-aws-ovn-shared-vpc-custom-security-groups
ci/prow/golint d6c4527 link true /test golint
ci/prow/unit d6c4527 link true /test unit
ci/prow/e2e-aws-ovn-imdsv2 d6c4527 link false /test e2e-aws-ovn-imdsv2
ci/prow/images d6c4527 link true /test images
ci/prow/e2e-aws-ovn-single-node d6c4527 link false /test e2e-aws-ovn-single-node
ci/prow/aws-private d6c4527 link false /test aws-private
ci/prow/e2e-aws-ovn-heterogeneous d6c4527 link false /test e2e-aws-ovn-heterogeneous
ci/prow/e2e-aws-ovn d6c4527 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-edge-zones d6c4527 link false /test e2e-aws-ovn-edge-zones
ci/prow/artifacts-images d6c4527 link true /test artifacts-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon approved these changes

@tthvo tthvo Awaiting requested review from tthvo

+1 more reviewer

@mtulio mtulio mtulio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jhixson74 @openshift-ci-robot @tthvo @mtulio @patrickdillon