Skip to content

Conversation

@lance5890
Copy link
Contributor

@lance5890 lance5890 commented Oct 1, 2025

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)
  1. The exporter and exporter has no need to use the imagePullPolicy: Always for the containers, as the ocp will replace the image: quay.io/openshift/origin-insights-runtime-exporter:latest to sha256 digest when create ocp release, the latest tag will not pull the latest image in the ocp versions.
  2. And if these containers restart and can not pull the image by some network reasons, the container will be stuck in pulling image .
      - name: exporter
          image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:3c414a2ccdc88d28f86d817df50747b324987666c043a090e84ab436a3750cab
          imagePullPolicy: Always
          volumeMounts:
            - mountPath: /data
              name: data-volume
          securityContext:
            privileged: false
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: true
            capabilities:
              drop:
                - ALL
          resources: 
            requests:
              cpu: 10m
              memory: 200Mi
        - name: extractor
          image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:01754384e79d97a9ef018c06032ffb80493de22e76f6c591e720d46d4e8f97a2
          imagePullPolicy: Always

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from ncaak and opokornyy October 1, 2025 00:58
@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign opokornyy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 1, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2025

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

memory: 100Mi
- name: exporter
image: quay.io/openshift/origin-insights-runtime-exporter:latest
imagePullPolicy: Always
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kube-rbac-proxy container has not set the Always imagePullPolicy

@opokornyy
Copy link
Contributor

/label ok-to-test

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

@opokornyy: Can not set label ok-to-test: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight openshift-sustaining-engineers]

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@opokornyy
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2025
@lance5890
Copy link
Contributor Author

/retest

2 similar comments
@opokornyy
Copy link
Contributor

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890 lance5890 force-pushed the set_imagePullPolicy_default branch from b0a19a3 to a0bc9a7 Compare October 19, 2025 00:24
@lance5890 lance5890 force-pushed the set_imagePullPolicy_default branch from a0bc9a7 to ff4c71b Compare October 25, 2025 00:39
@lance5890
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2025

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn ff4c71b link false /test okd-scos-e2e-aws-ovn
ci/prow/insights-operator-e2e-tests ff4c71b link true /test insights-operator-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants