-
Notifications
You must be signed in to change notification settings - Fork 256
OpenStack Hibernation #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msu8
wants to merge
11
commits into
openshift:master
Choose a base branch
from
msu8:openstack_hibernation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OpenStack Hibernation #2722
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4e05854
Implement OpenStack hibernation support
msu8 d177558
Add tests, better error handling, resource checking, finalize scripts
msu8 07cf30b
add docs, more changes
msu8 f3004f0
Merge branch 'openshift:master' into openstack_hibernation
msu8 cd33a48
- Address first wave of review feedback
msu8 546b625
Merge branch 'openstack_hibernation' of github.com:msu8/hive into ope…
msu8 541b6dd
Remove quota validation, structs, client creation from upstream, snap…
msu8 f2ca9e3
Merge branch 'master' into openstack_hibernation
msu8 33efb34
fix missing func for testing, try to fix dependencies
msu8 0728771
address idempotency, aggregate errors, filter using tags, handle 404/…
msu8 4e7ce15
run update-gofmt
msu8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ | |
| - [Handling Incompatible Cloud Provider](#handling-incompatible-cloud-provider) | ||
| - [Approving CSRs](#approving-csrs) | ||
| - [Resuming from a Hibernating State](#resuming-from-a-hibernating-state) | ||
| - [OpenStack Hibernation](#openstack-hibernation) | ||
|
|
||
| # Hibernating Clusters | ||
|
|
||
|
|
@@ -345,4 +346,22 @@ The unreachable controller tracks the reachability of a cluster and is responsib | |
|
|
||
| Once a cluster hibernates and stops responding, the unreachable controller sets the `Unreachable` condition's `Status` to `True`. | ||
|
|
||
| Once the cluster resumes, the unreachable controller set the condition `False` and the hive controllers are free to resume syncing. | ||
| Once the cluster resumes, the unreachable controller set the condition `False` and the hive controllers are free to resume syncing. | ||
|
|
||
| ## OpenStack Hibernation | ||
| OpenStack hibernation deletes cluster instances while preserving the ability to restore them. Unlike other cloud providers, OpenStack lacks native hibernation, therefore an implementation based on snapshots is necessary. | ||
|
|
||
| While OpenStack provides shelving functionality, replicating true hibernation behavior similar to other cloud providers is difficult and often not possible depending on the OpenStack deployment configuration. Hive's snapshot-based approach provides a universally compatible solution that works with any OpenStack setup. | ||
|
|
||
| OpenStack hibernation creates snapshots of all instances, saves their complete configuration into a secret (CD namespace), and deletes the instances, completely freeing all project resources consumed by the cluster. | ||
|
|
||
| Restoration recreates instances with identical attributes to their original state. | ||
|
|
||
| Due to the specific nature of the snapshot based implementation, the hibernation and restoration process inherently requires more time to finish compared to other cloud providers. | ||
|
|
||
| Once the ClusterPool is created and the cluster is claimed, the workflow is similar to other implementations: | ||
|
|
||
| ```bash | ||
| $ oc patch cd $cd -n $cd_ns --type='merge' -p $'spec:\n powerState: Hibernating' | ||
| $ oc patch cd $cd -n $cd_ns --type='merge' -p $'spec:\n powerState: Running' | ||
| ``` | ||
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Latent)