Skip to content

[release-4.19] OCPBUGS-62926: Add withCABundleDaemonSetHook() to AWS EFS operator #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

[release-4.19] OCPBUGS-62926: Add withCABundleDaemonSetHook() to AWS EFS operator #444

merged 1 commit into from
Oct 13, 2025

Conversation

mpatlasov
Copy link
Contributor

This is a manual cherry-pick of #441

https://issues.redhat.com/browse/OCPBUGS-61955

/cc @openshift/storage
/cc @openshift/storage-qe

@mpatlasov
Add withCABundleDaemonSetHook() to AWS EFS operator
1d8b30c 
The hook adds the custom CA bundle mount (non-standard-root-system-trust-ca-bundle). This CA bundle is critical for clusters running in the secure AWS regions (C2S/SC2S) because EFS requires these custom certificates to establish trust
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@mpatlasov: GitHub didn't allow me to request PR reviews from the following users: openshift/storage, openshift/storage-qe.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This is a manual cherry-pick of #441

https://issues.redhat.com/browse/OCPBUGS-61955

/cc @openshift/storage
/cc @openshift/storage-qe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-62926, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20.0" instead
  • expected Jira Issue OCPBUGS-62926 to depend on a bug targeting a version in 4.20.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #441

https://issues.redhat.com/browse/OCPBUGS-61955

/cc @openshift/storage
/cc @openshift/storage-qe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@mpatlasov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-62926, which is invalid:

  • expected Jira Issue OCPBUGS-62926 to depend on a bug targeting a version in 4.20.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mpatlasov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-62926, which is invalid:

  • expected dependent Jira Issue OCPBUGS-62688 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mpatlasov mpatlasov changed the title [release-4.20] OCPBUGS-62926: Add withCABundleDaemonSetHook() to AWS EFS operator [release-4.19] OCPBUGS-62926: Add withCABundleDaemonSetHook() to AWS EFS operator Oct 9, 2025
@mpatlasov
Copy link
Contributor Author

/cherry-pick release-4.18
/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@mpatlasov: once the present PR merges, I will cherry-pick it on top of release-4.17, release-4.18 in new PRs and assign them to you.

In response to this:

/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Phaow
Copy link
Contributor

Phaow commented Oct 10, 2025

/retest-required

1 similar comment
@Phaow
Copy link
Contributor

Phaow commented Oct 10, 2025

/retest-required

@Phaow
Copy link
Contributor

Phaow commented Oct 10, 2025

/verified by CI.
I could see the withCABundleDaemonSetHook hook works that the driver node daemonset pods mount the ca bundle comfigmap as expected.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 10, 2025
@openshift-ci-robot
Copy link

@Phaow: This PR has been marked as verified by CI..

In response to this:

/verified by CI.
I could see the withCABundleDaemonSetHook hook works that the driver node daemonset pods mount the ca bundle comfigmap as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor

Phaow commented Oct 10, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 10, 2025
@openshift-ci-robot
Copy link

@Phaow: This pull request references Jira Issue OCPBUGS-62926, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-62688 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-62688 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Phaow October 10, 2025 07:07
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025 •
edited
Loading

@mpatlasov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 1d8b30c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mpatlasov
Copy link
Contributor Author

/retest-required

@mpatlasov
Copy link
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 13, 2025
@Phaow
Copy link
Contributor

Phaow commented Oct 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@Phaow
Copy link
Contributor

Phaow commented Oct 13, 2025

/unassign @duanwei33 @chao007 @radeore

@openshift-merge-bot openshift-merge-bot bot merged commit 6936b18 into openshift:release-4.19 Oct 13, 2025
20 of 21 checks passed
@openshift-ci-robot
Copy link

@mpatlasov: Jira Issue Verification Checks: Jira Issue OCPBUGS-62926
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62926 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is a manual cherry-pick of #441

https://issues.redhat.com/browse/OCPBUGS-61955

/cc @openshift/storage
/cc @openshift/storage-qe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@mpatlasov: new pull request created: #447

In response to this:

/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 13, 2025
Open
@openshift-cherrypick-robot
Copy link

@mpatlasov: new pull request created: #448

In response to this:

/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 13, 2025
Closed
@Phaow Phaow mentioned this pull request Oct 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Phaow Phaow Awaiting requested review from Phaow

Assignees

@Phaow Phaow

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mpatlasov @openshift-ci-robot @openshift-cherrypick-robot @Phaow @chao007 @duanwei33 @radeore