CNTRLPLANE-1285: enable readOnlyRootFilesystem #419
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dusk125: This pull request references CNTRLPLANE-1285 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dusk125 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - name: csi-node-driver-registrar | ||
| securityContext: | ||
| privileged: true | ||
| readOnlyRootFilesystem: true |
There was a problem hiding this comment.
@dobsonj
How does privileged interact with readOnlyRootFilesystem? Will this make any change since we are already running it as privileged?
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
| containers: | ||
| - name: csi-liveness-probe | ||
| securityContext: | ||
| readOnlyRootFilesystem: true |
There was a problem hiding this comment.
This only add the controller sidecar, did not add readOnlyRootFilesystem to driver node.
Do we need to add this parameter to drive node?
There was a problem hiding this comment.
The driver assets should get the parameter from assets/common/readOnlyRootFilesystem.yaml: all of them get patched during the final assets generation IIUC. This actually might be problematic too since we can't exclude some of the drivers in case the readOnlyRootFilesystem would break them.
There was a problem hiding this comment.
I misunderstood your comment. And I think you're right -- some sidecars don't have the readOnlyFilesystem set it seems and on both node and controller.
|
Potentially dumb question arising out of openshift/hypershift#6885: do we need to mount |
openshift-merge-robot
added
the
needs-rebase
Some need it, some don't. It really just depends on whether or not something needs to/expects to write to /tmp. I added it by default because usually it's a safe assumption that something will write to it, but in some cases it doesn't.... I should probably add it to these :) |
openshift-merge-robot
removed
the
needs-rebase
|
@dusk125: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7 participants
No description provided.