Skip to content

Conversation

@fallmo
Copy link

@fallmo fallmo commented Nov 1, 2025

Untitled

Safari does not properly constrain images using max-height: 100% when the parent element has a fixed max-height. As a result, the custom masthead logo ignores the intended 60 px limit on Safari.

This change explicitly applies max-height: 60px to the child img element to ensure consistent behavior across browsers.

Explicitly set max-height for browser compatibility (safari)

Signed-off-by: Mohamed Fall <[email protected]>
@openshift-ci openshift-ci bot requested review from rhamilto and sg00dwin November 1, 2025 13:39
@openshift-ci openshift-ci bot added component/core Related to console core functionality needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2025

Hi @fallmo. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhamilto
Copy link
Member

rhamilto commented Nov 5, 2025

/assign @sg00dwin

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2025
@fallmo
Copy link
Author

fallmo commented Nov 7, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

@fallmo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fallmo, logonoff, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Member

logonoff commented Nov 7, 2025

/retitle NO-JIRA: Fix logo max-height not respected on Safari
/label px-approved
/label docs-approved

qe review:
/assign @yapei

@openshift-ci openshift-ci bot changed the title Fix logo max-height not respected on Safari NO-JIRA: Fix logo max-height not respected on Safari Nov 7, 2025
@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

@fallmo: This pull request explicitly references no jira issue.

In response to this:

Untitled

Safari does not properly constrain images using max-height: 100% when the parent element has a fixed max-height. As a result, the custom masthead logo ignores the intended 60 px limit on Safari.

This change explicitly applies max-height: 60px to the child img element to ensure consistent behavior across browsers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants