NO-JIRA: add claude /plugin-api-review command

[logonoff]

example output from #15655

Plugin API Review Report

API change: Internal refactoring to always use canonical model references
JIRA issue: CONSOLE-4837
Current OpenShift version: 4.21
Changes to changelog made? N/A - No plugin API changes

Summary

The changes in this branch are internal console refactoring and do not affect the plugin API. The modified files are:

• frontend/public/components/utils/resource-link.tsx - Simplified to always use referenceForModel() instead of conditionally using plural or referenceForModel based on CRD status
• frontend/public/kinds.ts - Added new usePlural hook (hook version of connectToPlural) for internal console use

These files are not part of the @openshift-console/dynamic-plugin-sdk package and are not exported as shared modules or extension APIs. They are internal console implementation files in the frontend/public directory.

Findings

•  Reviewed changes for plugin API impact - No plugin API changes detected
•  Verified that the change does not need to be documented in the "Changes to plugin API" section of the dynamic plugin SDK release notes - not applicable
•  Verified that the change does not need to be documented in the "Changes to shared modules and API" section of the dynamic plugin SDK release notes - not applicable
•  Verified that the change does not need to be documented in the SDK core changelog - not applicable
•  Verified that the change does not need to be documented in the SDK webpack changelog - not applicable
•  Verified that no CSS class changes require documentation - no CSS files modified
•  Verified that a JIRA issue is associated with the change - CONSOLE-4837
•  Verified that the styleguide is followed for all changed files

Issues found during review

Code Quality Observations (not plugin API compliance issues):

1. In frontend/public/kinds.ts, the usePlural function calls buildK8sKind() with the result of modelMetadata.find() which can return undefined. This may cause runtime errors if no matching metadata is found.
2. Potential null reference in buildK8sKind where metadata.properties?.labelPlural.toLowerCase() doesn't use optional chaining on the .toLowerCase() call.

These are internal implementation issues and do not affect plugin API compliance.

Actions taken

None required - no plugin API changes to document.

Compliance score: 10/10

Reason for score:

• All plugin API review criteria are satisfied
• No plugin API changes were made, so no changelog documentation is required
• JIRA issue (CONSOLE-4837) is properly associated with the changes
• The styleguide is followed for all changed files
• Changes are purely internal refactoring that do not affect dynamic plugins

[openshift-ci-robot]

@logonoff: This pull request explicitly references no jira issue.

In response to this:

example output from #15655

Plugin API Review Report

API change: Internal refactoring to always use canonical model references
JIRA issue: CONSOLE-4837
Current OpenShift version: 4.21
Changes to changelog made? N/A - No plugin API changes

Summary

The changes in this branch are internal console refactoring and do not affect the plugin API. The modified files are:

• frontend/public/components/utils/resource-link.tsx - Simplified to always use referenceForModel() instead of conditionally using plural or referenceForModel based on CRD status
• frontend/public/kinds.ts - Added new usePlural hook (hook version of connectToPlural) for internal console use

These files are not part of the @openshift-console/dynamic-plugin-sdk package and are not exported as shared modules or extension APIs. They are internal console implementation files in the frontend/public directory.

Findings

•  Reviewed changes for plugin API impact - No plugin API changes detected
•  Verified that the change does not need to be documented in the "Changes to plugin API" section of the dynamic plugin SDK release notes - not applicable
•  Verified that the change does not need to be documented in the "Changes to shared modules and API" section of the dynamic plugin SDK release notes - not applicable
•  Verified that the change does not need to be documented in the SDK core changelog - not applicable
•  Verified that the change does not need to be documented in the SDK webpack changelog - not applicable
•  Verified that no CSS class changes require documentation - no CSS files modified
•  Verified that a JIRA issue is associated with the change - CONSOLE-4837
•  Verified that the styleguide is followed for all changed files

Issues found during review

Code Quality Observations (not plugin API compliance issues):

1. In frontend/public/kinds.ts, the usePlural function calls buildK8sKind() with the result of modelMetadata.find() which can return undefined. This may cause runtime errors if no matching metadata is found.
2. Potential null reference in buildK8sKind where metadata.properties?.labelPlural.toLowerCase() doesn't use optional chaining on the .toLowerCase() call.

These are internal implementation issues and do not affect plugin API compliance.

Actions taken

None required - no plugin API changes to document.

Compliance score: 10/10

Reason for score:

• All plugin API review criteria are satisfied
• No plugin API changes were made, so no changelog documentation is required
• JIRA issue (CONSOLE-4837) is properly associated with the changes
• The styleguide is followed for all changed files
• Changes are purely internal refactoring that do not affect dynamic plugins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/backend	9452683	link	true	/test backend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[logonoff]

/verified bypass
/label px-approved
/label docs-approved

[openshift-ci-robot]

@logonoff: The verified label has been added.

In response to this:

/verified bypass
/label px-approved
/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Leo6Leo]

/meow

[openshift-ci]

@Leo6Leo:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.