CONSOLE-4841: Move CSP from plugin to redux store + some sdk adoption prep work #15633

logonoff · 2025-10-23T04:04:44Z

CSP violations are now stored in the store.UI.pluginCSPViolations[pluginName] as a boolean for whether a violation has been committed.

Removes setCustomDynamicPluginInfo and findDynamicPluginInfo because they will not be included in openshift/dynamic-plugin-sdk.

There should be no functional or UI changes in this PR, everything should remain the same to an end user.

openshift-ci-robot · 2025-10-23T04:04:48Z

@logonoff: This pull request references CONSOLE-4841 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

CSP violations are now stored in the store.UI.pluginCSPViolations[pluginName] as a boolean for whether a violation has been committed.

Removes setCustomDynamicPluginInfo and findDynamicPluginInfo because they will not be included in openshift/dynamic-plugin-sdk.

There should be no functional or UI changes in this PR, everything should remain the same to an end user.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-10-23T04:04:56Z

/label px-approved
/label docs-approved

/assign @yapei @vojtechszocs

frontend/public/actions/ui.ts

frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx

...tend/packages/console-app/src/components/console-operator/ConsolePluginDescriptionDetail.tsx

yapei · 2025-10-27T08:02:05Z

frontend/packages/console-plugin-sdk/src/api/usePluginInfo.ts

 * @returns Console dynamic plugin runtime information.
 */
-export const useDynamicPluginInfo = (): [DynamicPluginInfo[], boolean] => {
+export const usePluginInfo = (): [DynamicPluginInfo[], boolean] => {


Hi, why do we remove dynamic from name? any special consideration?

We will be transitioning to a new SDK which uses the name usePluginInfo

https://github.com/openshift/dynamic-plugin-sdk/blob/main/packages/lib-core/src/runtime/usePluginInfo.ts

So I'm changing the name here in preparation

Right, this is just to align with upcoming change to use the runtime (core) package from the above mentioned repo.

yapei · 2025-10-27T08:39:29Z

performed some testing about dynamic plugin CSP status checking in Dynamic Plugin status card and ConsolePlugins list table

no regression issues found

openshift-ci-robot · 2025-10-31T13:36:15Z

@logonoff: This PR has been marked as verified by yapei.

In response to this:

just a rebase

/verified by yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vojtechszocs · 2025-11-04T18:35:01Z

...tend/packages/console-app/src/components/console-operator/ConsolePluginDescriptionDetail.tsx

+      pluginInfoEntries.find((entry) =>
+        isLoadedDynamicPluginInfo(entry)
+          ? entry.metadata.name === pluginName
+          : entry.pluginName === pluginName,


FYI - in [1] we need a manifest object (provided either directly or via URL) before loading a plugin, so this code should become more simple in future, e.g. entry.manifest.name.

[1] https://github.com/openshift/dynamic-plugin-sdk/blob/main/packages/lib-core/src/types/store.ts

...app/src/components/dashboards-page/dynamic-plugins-health-resource/DynamicPluginsPopover.tsx

vojtechszocs · 2025-11-04T18:55:19Z

frontend/packages/console-plugin-sdk/src/api/pluginSubscriptionService.ts

 * - **Yes**
- *   - Functional components: use `useExtensions` hook.
- *   - Class components: use `withExtensions` higher-order component.
+ *   - Use `useExtensions` hook.


👍 thanks for updating code docs

vojtechszocs · 2025-11-04T18:57:32Z

frontend/packages/console-plugin-sdk/src/api/usePluginInfo.ts

 * @returns Console dynamic plugin runtime information.
 */
-export const useDynamicPluginInfo = (): [DynamicPluginInfo[], boolean] => {
+export const usePluginInfo = (): [DynamicPluginInfo[], boolean] => {


Right, this is just to align with upcoming change to use the runtime (core) package from the above mentioned repo.

logonoff · 2025-11-04T19:06:03Z

reapplying verified because the suggestion doesn't have any functional impact

/verified by yapei

openshift-ci-robot · 2025-11-04T19:06:17Z

@logonoff: This PR has been marked as verified by yapei.

In response to this:

reapplying verified because the suggestion doesn't have any functional impact

/verified by yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-11-04T19:57:15Z

rebase

/verified by yapei

openshift-ci-robot · 2025-11-04T19:57:26Z

@logonoff: This PR has been marked as verified by yapei.

In response to this:

rebase

/verified by yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

CSP violations are now stored in the `store.UI.pluginCSPViolations[pluginName]` as a boolean for whether a violation has been committed. Removes `setCustomDynamicPluginInfo` and `findDynamicPluginInfo` because they will not be included in `openshift/dynamic-plugin-sdk`. There should be no functional or UI changes in this PR, everything should remain the same to an end user.

Also remove `usePluginInfo` and `usePluginStore` from the barrel file so we can move towards removing the barrel file entirely

It's used in one spot which we can remove

logonoff · 2025-11-05T03:45:53Z

rebase

/verified by yapei

openshift-ci-robot · 2025-11-05T03:46:04Z

@logonoff: This PR has been marked as verified by yapei.

In response to this:

rebase

/verified by yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vojtechszocs · 2025-11-05T14:31:37Z

/lgtm

openshift-ci · 2025-11-05T14:32:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-11-06T02:04:04Z

/retest-required

Remaining retests: 0 against base HEAD 9dcc55d and 2 for PR HEAD 77967b5 in total

openshift-ci · 2025-11-06T06:23:49Z

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`77967b5`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-11-06T07:04:06Z

/retest-required

Remaining retests: 0 against base HEAD c8d3ac2 and 1 for PR HEAD 77967b5 in total

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2025

openshift-ci bot assigned vojtechszocs and yapei Oct 23, 2025

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 23, 2025

openshift-ci bot requested review from TheRealJon and jhadvig October 23, 2025 04:05

openshift-ci bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2025

vojtechszocs suggested changes Oct 23, 2025

View reviewed changes

logonoff force-pushed the CONSOLE-4841-csp branch from f6d4500 to ec2bf9d Compare October 23, 2025 20:26

openshift-ci bot added the component/shared Related to console-shared label Oct 23, 2025

logonoff force-pushed the CONSOLE-4841-csp branch 4 times, most recently from 8c88a87 to 543a22c Compare October 23, 2025 20:35

openshift-ci bot added component/dashboard Related to dashboard component/topology Related to topology labels Oct 23, 2025

logonoff force-pushed the CONSOLE-4841-csp branch from b78cc39 to c9cc5f5 Compare October 23, 2025 20:48

logonoff changed the title ~~CONSOLE-4841: Move CSP from plugin to redux store~~ CONSOLE-4841: Move CSP from plugin to redux store + some sdk adoption prep work Oct 23, 2025

logonoff force-pushed the CONSOLE-4841-csp branch 4 times, most recently from 7717f17 to 9073393 Compare October 27, 2025 04:05

yapei reviewed Oct 27, 2025

View reviewed changes

logonoff force-pushed the CONSOLE-4841-csp branch from 9073393 to ea697af Compare October 27, 2025 22:01

vojtechszocs reviewed Nov 4, 2025

View reviewed changes

vojtechszocs suggested changes Nov 4, 2025

View reviewed changes

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 4, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 4, 2025

logonoff force-pushed the CONSOLE-4841-csp branch from 2efccb1 to db1f638 Compare November 4, 2025 19:56

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 4, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 4, 2025

logonoff added 7 commits November 4, 2025 22:45

CONSOLE-4841: Rename getExtensionsInUse to getExtensions

71d859f

CONSOLE-4841: Rename getDynamicPluginInfo to getPluginInfo

100d728

CONSOLE-4841: Rename useDynamicPluginInfo to usePluginInfo

4c1e9a8

CONSOLE-4841: Use usePluginInfo to get plugin info

2b1399d

Also remove `usePluginInfo` and `usePluginStore` from the barrel file so we can move towards removing the barrel file entirely

CONSOLE-4841: Remove withExtensions HOC

51299f8

It's used in one spot which we can remove

CONSOLE-4841: Remove useExtensions from barrel

77967b5

logonoff force-pushed the CONSOLE-4841-csp branch from db1f638 to 77967b5 Compare November 5, 2025 03:45

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 5, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 5, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025

CONSOLE-4841: Move CSP from plugin to redux store + some sdk adoption prep work #15633

Are you sure you want to change the base?

CONSOLE-4841: Move CSP from plugin to redux store + some sdk adoption prep work #15633

Conversation

logonoff commented Oct 23, 2025

Uh oh!

openshift-ci-robot commented Oct 23, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logonoff commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yapei Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

logonoff Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

vojtechszocs Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

yapei commented Oct 27, 2025

Uh oh!

openshift-ci-robot commented Oct 31, 2025

Uh oh!

vojtechszocs Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vojtechszocs Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

vojtechszocs Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

logonoff commented Nov 4, 2025

Uh oh!

openshift-ci-robot commented Nov 4, 2025

Uh oh!

logonoff commented Nov 4, 2025

Uh oh!

openshift-ci-robot commented Nov 4, 2025

Uh oh!

logonoff commented Nov 5, 2025

Uh oh!

openshift-ci-robot commented Nov 5, 2025

Uh oh!

vojtechszocs commented Nov 5, 2025

Uh oh!

openshift-ci bot commented Nov 5, 2025

Uh oh!

openshift-ci-robot commented Nov 6, 2025

Uh oh!

openshift-ci bot commented Nov 6, 2025

Uh oh!

openshift-ci-robot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Oct 23, 2025 •

edited by openshift-ci bot

Loading