OCPBUGS-63339: HPA Form View in RHOCP Web Console Incorrectly Requires Both CPU and …

[cajieh]

The Alignment Between HPA Form Behavior and the API

A breakdown of the key points regarding the Horizontal Pod Autoscaler (HPA) form's behavior and how it aligns with API:

API Default Behavior:
If the spec.metrics array in an HPA manifest is empty ([]) or omitted, API automatically defaults to scaling based on 80% average CPU utilization.

API Validation Rule for Utilization:
If you specify a metric with target.type utilization (like CPU or Memory), the averageUtilization value "must be greater than 0". A value of 0 is invalid and will be rejected by the Kubernetes API server.

UI Form Behavior:
Empty Input Field: If a user leaves the CPU or Memory utilization field empty, the UI omits that specific metric from the generated HPA manifest/request.

• This allows users to create single-metric HPAs (e.g., Memory only).
• If both fields are left empty, API applies its 80% CPU default.

Input Value = '0': If a user enters 0 in the CPU or Memory utilization field, the UI sends this value to the API server. The API server then rejects the request with the "must be greater than 0" error, which is the current and expected behavior.

Input Value > 0: The UI includes the specified metric values in the HPA manifest/request, which are then sent successfully to the API.

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-63339, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…Memory Metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yanpzhan]

@cajieh Checked on cluster launched against the pr. On HPA create/edit form view page, user could set '0' for CPU Utilization。
But when set '0' for Memory Utilization, it still prompts error "Danger alert:An error occurred
Error "Invalid value: 0: must be greater than 0" for field "spec.metrics[1].resource.target.averageUtilization"."
If user set '0' for CPU Utilization, set a valid number eg '10' for Memory Utilization, HPA could be created/saved, but there will be duplicated memory metrics info in yaml.

# oc get hpa example -n protest --kubeconfig 15626.kubeconfig -ojson | jq '.spec.metrics'
[
  {
    "resource": {
      "name": "memory",
      "target": {
        "averageUtilization": 10,
        "type": "Utilization"
      }
    },
    "type": "Resource"
  },
  {
    "resource": {
      "name": "memory",
      "target": {
        "averageUtilization": 10,
        "type": "Utilization"
      }
    },
    "type": "Resource"
  }
]

[cajieh]

@cajieh Checked on cluster launched against the pr. On HPA create/edit form view page, user could set '0' for CPU Utilization。 But when set '0' for Memory Utilization, it still prompts error "Danger alert:An error occurred Error "Invalid value: 0: must be greater than 0" for field "spec.metrics[1].resource.target.averageUtilization"." If user set '0' for CPU Utilization, set a valid number eg '10' for Memory Utilization, HPA could be created/saved, but there will be duplicated memory metrics info in yaml.

# oc get hpa example -n protest --kubeconfig 15626.kubeconfig -ojson | jq '.spec.metrics'
[
  {
    "resource": {
      "name": "memory",
      "target": {
        "averageUtilization": 10,
        "type": "Utilization"
      }
    },
    "type": "Resource"
  },
  {
    "resource": {
      "name": "memory",
      "target": {
        "averageUtilization": 10,
        "type": "Utilization"
      }
    },
    "type": "Resource"
  }
]

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-63339. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

…Memory Metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-63339, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…Memory Metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cajieh]

duplicated memory metrics info in yaml

@yanpzhan Thank you for verifying quickly. However, the error—Error "Invalid value: 0: must be greater than 0" for field "spec.metrics[1].resource.target.averageUtilization" is coming directly from the API server. This behavior is expected for both CPU and Memory Utilization, as Kubernetes validation requires the averageUtilization value to be greater than 0.
Also, in the scenario where a user sets '0' for CPU Utilization but provides a valid number (e.g., '10') for Memory Utilization, HPA creation should fail and throw an API server error. But it appears the console UI might be removing the '0' value for CPU before sending the request. However, the HPA can be created without defining both the CPU and Memory averageUtilization values.
The issue with duplicated Memory metrics info in the YAML will be fixed.

[cajieh]

Unsure why the default value for the UI was different from the API default. Changed it to be consistent with the API default.

[yanpzhan]

@cajieh when create HPA on form view, leave CPU Utilization and Memory Utilization fields empty, click create. The hpa will only have default value 80 for CPU Utilization, so if there is not a requirement for Memory Utilization default value?

[cajieh]

@cajieh when create HPA on form view, leave CPU Utilization and Memory Utilization fields empty, click create. The hpa will only have default value 80 for CPU Utilization, so if there is not a requirement for Memory Utilization default value?

@yanpzhan Correct. This change removes the default value for the Memory Utilization field. The intention is to align with the oc CLI's behavior, unless anyone has a strong justification for not doing so.
cc: @vikram-raj @jhadvig

[cajieh]

/test okd-scos-e2e-aws-ovn

[cajieh]

/jira refresh

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-63339, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yanpzhan]

The update LGTM now.
/verified by @yanpzhan

[openshift-ci-robot]

@yanpzhan: This PR has been marked as verified by @yanpzhan.

In response to this:

The update LGTM now.
/verified by @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cajieh]

/retest

[vikram-raj]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [cajieh,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@cajieh: Jira Issue Verification Checks: Jira Issue OCPBUGS-63339
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63339 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

The Alignment Between HPA Form Behavior and the API

A breakdown of the key points regarding the Horizontal Pod Autoscaler (HPA) form's behavior and how it aligns with API:

API Default Behavior:
If the spec.metrics array in an HPA manifest is empty ([]) or omitted, API automatically defaults to scaling based on 80% average CPU utilization.

API Validation Rule for Utilization:
If you specify a metric with target.type utilization (like CPU or Memory), the averageUtilization value "must be greater than 0". A value of 0 is invalid and will be rejected by the Kubernetes API server.

UI Form Behavior:
Empty Input Field: If a user leaves the CPU or Memory utilization field empty, the UI omits that specific metric from the generated HPA manifest/request.

• This allows users to create single-metric HPAs (e.g., Memory only).
• If both fields are left empty, API applies its 80% CPU default.

Input Value = '0': If a user enters 0 in the CPU or Memory utilization field, the UI sends this value to the API server. The API server then rejects the request with the "must be greater than 0" error, which is the current and expected behavior.

Input Value > 0: The UI includes the specified metric values in the HPA manifest/request, which are then sent successfully to the API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cajieh]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@cajieh: new pull request created: #15673

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.