-
Notifications
You must be signed in to change notification settings - Fork 209
NO-JIRA: Move constants of ClusterStatusConditionType into one place #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hongkailiu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6150d88 to
cd6c7c2
Compare
|
With 36fb0ca,
|
We cannot keep them in `pkg/cvo/status.go` as it would create dependency cycles.
36fb0ca to
bfc7f69
Compare
|
/test e2e-extended-tests |
|
/test e2e-hypershift |
|
@hongkailiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No regression issue found in above test, the failed two cases in e2e-extended-tests are both automation issues. |

We cannot keep them in
pkg/cvo/status.goas it would createdependency cycles.