Skip to content

Conversation

@hongkailiu
Copy link
Member

We cannot keep them in pkg/cvo/status.go as it would create
dependency cycles.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

We cannot keep them in pkg/cvo/status.go as it would create
dependency cycles.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@hongkailiu hongkailiu force-pushed the ClusterStatusConditionType branch 5 times, most recently from 6150d88 to cd6c7c2 Compare October 29, 2025 23:15
@hongkailiu
Copy link
Member Author

With 36fb0ca, ClusterStatusConditionType is used only in a few places where they look very reasonable.

Screenshot 2025-10-29 at 19 39 28

We cannot keep them in `pkg/cvo/status.go` as it would create
dependency cycles.
@hongkailiu hongkailiu force-pushed the ClusterStatusConditionType branch from 36fb0ca to bfc7f69 Compare October 30, 2025 14:17
@JianLi-RH
Copy link
Contributor

/test e2e-extended-tests

@hongkailiu
Copy link
Member Author

/test e2e-hypershift

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-extended-tests bfc7f69 link false /test e2e-extended-tests
ci/prow/e2e-hypershift bfc7f69 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiajliu
Copy link

jiajliu commented Nov 4, 2025

e2e-extended-tests — Job failed.

No regression issue found in above test, the failed two cases in e2e-extended-tests are both automation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants