CORENET-6423: api, l2udn: subnets must be masked #2808
Conversation
|
@kyrtapz FYI |
maiqueb
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@maiqueb: This pull request references CORENET-6423 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@maiqueb: This pull request references CORENET-6423 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@maiqueb there are two CRDs in that file we need to update, CUDN and UDN |
Right. On it. |
For backwards compatibility reasons, we cannot update the definition of all the attributes that use the CIDR type - only of the new, unreleased objects. Hence, this check is only performed for the `reservedSubnets` and `infrastructureSubnets` attributes in both the UDN and C-UDN CRDs. Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
api-l2udn-masked-subnets
branch
from
f2cb59c to
2f74606
Compare
|
/retest-required |
|
/lgtm |
|
/test ? |
|
@kyrtapz: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Lets make sure TechPreview is fine (not seeing any ran) |
|
/test e2e-aws-ovn-techpreview-serial-2of2 Retesting this failed TP job. |
|
/verified by @asood-rh |
openshift-ci-robot
added
the
verified
|
@asood-rh: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@maiqueb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
For backwards compatibility reasons, we cannot update the definition of all the attributes that use the CIDR type - only of the new, unreleased objects.
Hence, this check is only performed for the
reservedSubnetsandinfrastructureSubnetsattributes.