Skip to content

Conversation

sadasu
Copy link

@sadasu sadasu commented Sep 23, 2025

  1. Added AWS and Azure as platforms that support DualStack on Day-0
  2. Added AWS, Azure and OpenStack as platforms that do not support conversion to DualStack on Day-2.
  3. Updated tests to reflect the newly supported platforms and when they support DualStack.
  4. Currently DualStack for AWS and Azure are behind featuregates. Updated to check that these featuregates are enabled before DualStack support is extended to these platforms.

Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadasu
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu sadasu changed the title Allow AWS and Azure as platforms that support dual-stack on Day-0 CORS-4180: Allow AWS and Azure as platforms that support dual-stack on Day-0 Sep 23, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 23, 2025

@sadasu: This pull request references CORS-4180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  1. Added AWS and Azure as platforms that support DualStack on Day-0
  2. Added AWS, Azure and OpenStack as platforms that do not support conversion to DualStack on Day-2.
  3. Updated tests to reflect the newly supported platforms and when they support DualStack.

Developed with Cursor.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 23, 2025

@sadasu: This pull request references CORS-4180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  1. Added AWS and Azure as platforms that support DualStack on Day-0
  2. Added AWS, Azure and OpenStack as platforms that do not support conversion to DualStack on Day-2.
  3. Updated tests to reflect the newly supported platforms and when they support DualStack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link
Author

sadasu commented Sep 23, 2025

/retest-required

@patrickdillon
Copy link

This looks good to me. AWS tests are failing to find a lease... i think we're hitting ci infra problems.

@sadasu
Copy link
Author

sadasu commented Sep 24, 2025

/retest-required

@sadasu sadasu force-pushed the update-for-dualstack branch from 4696a48 to 621b294 Compare October 3, 2025 14:02
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2025

@sadasu: This pull request references CORS-4180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  1. Added AWS and Azure as platforms that support DualStack on Day-0
  2. Added AWS, Azure and OpenStack as platforms that do not support conversion to DualStack on Day-2.
  3. Updated tests to reflect the newly supported platforms and when they support DualStack.
  4. Currently DualStack for AWS and Azure are behind featuregates. Updated to check that these featuregates are enabled before DualStack support is extended to these platforms.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu added 3 commits October 3, 2025 10:11
Bringing in the feature gates added for AWS and Azure DualStack
support.
This is required to bring in the lastest featuregates
1. Added AWS and Azure as platforms that support DualStack on Day-0
2. Added AWS, Azure and OpenStack as platforms that do not support
conversion to DualStack on Day-2.
3. Updated tests to reflect the newly supported platforms and when
they support DualStack.

Developed with Cursor.
@sadasu sadasu force-pushed the update-for-dualstack branch from 621b294 to 9fbf4db Compare October 3, 2025 14:12
@sadasu
Copy link
Author

sadasu commented Oct 8, 2025

/jira-refresh

@sadasu
Copy link
Author

sadasu commented Oct 14, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 9fbf4db link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node 9fbf4db link false /test e2e-aws-ovn-single-node
ci/prow/okd-scos-e2e-aws-ovn 9fbf4db link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-dualstack 9fbf4db link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-network-mtu-migration-ovn-ipv4 9fbf4db link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade 9fbf4db link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/e2e-aws-hypershift-ovn-kubevirt 9fbf4db link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/security 9fbf4db link false /test security
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade 9fbf4db link false /test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/e2e-azure-ovn 9fbf4db link false /test e2e-azure-ovn
ci/prow/e2e-azure-ovn-upgrade 9fbf4db link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp 9fbf4db link true /test e2e-metal-ipi-ovn-dualstack-bgp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants