OCPBUGS-58306: Disable network segmentation when multus is disabled

[ricky-rav]

Network segmentation requires multus to be enabled. If the user disables multus (multi networks), we should also disable network segmentation.
Since network segmentation is on by default, we have to disable it explicitly if we find disableMultiNetwork=true

[openshift-ci-robot]

@ricky-rav: This pull request references Jira Issue OCPBUGS-58306, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricky-rav
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ricky-rav]

/jira refresh

[openshift-ci-robot]

@ricky-rav: This pull request references Jira Issue OCPBUGS-58306, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ricky-rav]

/retest

[openshift-ci-robot]

@ricky-rav: This pull request references Jira Issue OCPBUGS-58306, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Network segmentation requires multus to be enabled. If the user disables multus (multi networks), we should also disable network segmentation.
Since network segmentation is on by default, we have to disable it explicitly if we find disableMultiNetworks=true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ricky-rav]

/retest

[ricky-rav]

@kyrtapz PTAL

[kyrtapz]

@ricky-rav @anuragthehatter do we have any coverage for disableMultiNetwork=true?
Do we need to add a CI job?

[ricky-rav]

@ricky-rav @anuragthehatter do we have any coverage for disableMultiNetwork=true? Do we need to add a CI job?

There's nothing in origin for disableMultiNetwork. Do we care enough about this to have a dedicated lane for it?

[ricky-rav]

/retest

[ricky-rav]

/retest

[openshift-ci]

@ricky-rav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	e9938e1	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade	e9938e1	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-serial	e9938e1	link	false	/test e2e-aws-ovn-serial
ci/prow/e2e-aws-hypershift-ovn-kubevirt	e9938e1	link	false	/test e2e-aws-hypershift-ovn-kubevirt
ci/prow/security	e9938e1	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.