Skip to content

CNF-16707: frr-k8s: wire the frr-status sidecar container #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CNF-16707: frr-k8s: wire the frr-status sidecar container #2687

wants to merge 1 commit into from
+41 −0

Conversation

oribon
Copy link
Contributor

@oribon oribon commented Apr 15, 2025

Now that the changes are merged in the code, we
can update the manifests to include the frr-status exporter in charge of creating the actual resources.

@openshift-ci openshift-ci bot requested review from danwinship and tssurya April 15, 2025 09:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@oribon
Copy link
Contributor Author

oribon commented Apr 15, 2025

/retest-required

2 similar comments
@oribon
Copy link
Contributor Author

oribon commented Apr 16, 2025

/retest-required

@oribon
Copy link
Contributor Author

oribon commented Apr 16, 2025

/retest-required

@oribon
frr-k8s: wire the frr-status sidecar container
6e56372 
Now that the changes are merged in the frr-k8s repo, we
can update the manifests to include the frr-status
exporter in charge of creating the actual BGPSessionState resources.
The BGPSessionState CRD was brought in a previous commit, and it
exposes the status of a BGP session from the FRR instance
running on each node.

Signed-off-by: Ori Braunshtein <[email protected]>
@oribon oribon force-pushed the frrk8s_bgpsessionstates_sidecar branch from 67fab40 to 6e56372 Compare April 16, 2025 11:35
@fedepaol
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, oribon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oribon oribon changed the title frr-k8s: wire the frr-status sidecar container CNF-16707: frr-k8s: wire the frr-status sidecar container Apr 16, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@oribon: This pull request references CNF-16707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Now that the changes are merged in the code, we
can update the manifests to include the frr-status exporter in charge of creating the actual resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0508612 and 2 for PR HEAD 6e56372 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0508612 and 2 for PR HEAD 6e56372 in total

@oribon
Copy link
Contributor Author

oribon commented Apr 17, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 50405c0 and 2 for PR HEAD 6e56372 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 50405c0 and 2 for PR HEAD 6e56372 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 18, 2025

@oribon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frrk8s-e2e 67fab40 link false /test frrk8s-e2e
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 67fab40 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-serial 67fab40 link false /test e2e-aws-ovn-serial
ci/prow/e2e-aws-hypershift-ovn-kubevirt 67fab40 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/security 67fab40 link false /test security
ci/prow/e2e-network-mtu-migration-ovn-ipv6 67fab40 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade 67fab40 link false /test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/e2e-openstack-ovn 67fab40 link false /test e2e-openstack-ovn
ci/prow/e2e-vsphere-ovn-dualstack 67fab40 link false /test e2e-vsphere-ovn-dualstack
ci/prow/okd-scos-e2e-aws-ovn 67fab40 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn 67fab40 link false /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-upgrade 6e56372 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 6e56372 link true /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-aws-ovn-ipsec-upgrade 6e56372 link true /test e2e-aws-ovn-ipsec-upgrade
ci/prow/e2e-ovn-ipsec-step-registry 6e56372 link true /test e2e-ovn-ipsec-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@fedepaol fedepaol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oribon @fedepaol @openshift-ci-robot