Skip to content

OCPBUGS-62276: add tls configuration for the monitoring plugin deployment #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

OCPBUGS-62276: add tls configuration for the monitoring plugin deployment #2706

merged 1 commit into from
Oct 16, 2025
+18 −8

Conversation

jgbernalp
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 10, 2025
@openshift-ci-robot
Copy link
Contributor

@jgbernalp: This pull request references Jira Issue OCPBUGS-62276, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp jgbernalp marked this pull request as draft October 10, 2025 09:31
@jgbernalp
Copy link
Contributor Author

Requires openshift/monitoring-plugin#580

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
@openshift-ci openshift-ci bot requested review from rexagod and slashpai October 10, 2025 09:32
@simonpasquier
Copy link
Contributor

/cc @simonpasquier

@openshift-ci openshift-ci bot requested a review from simonpasquier October 10, 2025 09:36
@jgbernalp jgbernalp force-pushed the add-tls-config-for-console-plugin branch from bfe7515 to b251e2b Compare October 10, 2025 09:37
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 10, 2025
Merged
@jgbernalp jgbernalp marked this pull request as ready for review October 10, 2025 13:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
@simonpasquier
Copy link
Contributor

/retest

@juzhao
Copy link
Contributor

juzhao commented Oct 14, 2025

/test generate

@juzhao
Copy link
Contributor

juzhao commented Oct 14, 2025

/testwith ci/prow/generate openshift/monitoring-plugin#580

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@juzhao, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: ci/prow/generate

@juzhao
Copy link
Contributor

juzhao commented Oct 14, 2025

/testwith generate openshift/monitoring-plugin#580

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@juzhao, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: generate

@juzhao
Copy link
Contributor

juzhao commented Oct 14, 2025

generate keep failing for

+ jsonnet -J jsonnet/vendor -J tmp/json-manifests jsonnet/main.jsonnet
RUNTIME ERROR: Field does not exist: tlsCipherSuites
	jsonnet/components/monitoring-plugin.libsonnet:204:44-63	thunk from <object <anonymous>>
	Array element 4	
	Field "args"	
	Array element 0	
	Field "containers"	
	Field "spec"	
	Field "template"	
	Field "spec"	
	Field "monitoring-plugin/deployment"	
	During manifestation

maybe we need to define tlsCipherSuites in the cfg object

@jgbernalp jgbernalp force-pushed the add-tls-config-for-console-plugin branch from b251e2b to 078d0c1 Compare October 14, 2025 08:18
@jgbernalp
Copy link
Contributor Author

/retest-required

@juzhao
Copy link
Contributor

juzhao commented Oct 14, 2025

/retest

@juzhao
Copy link
Contributor

juzhao commented Oct 15, 2025

/test e2e-aws-ovn

@juzhao
Copy link
Contributor

juzhao commented Oct 15, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@juzhao
Copy link
Contributor

juzhao commented Oct 16, 2025

/verified by @juzhao

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 16, 2025
@openshift-ci-robot
Copy link
Contributor

@juzhao: This PR has been marked as verified by @juzhao.

In response to this:

/verified by @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier
simonpasquier reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@simonpasquier
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e9126a5 into openshift:main Oct 16, 2025
21 checks passed
@openshift-ci-robot
Copy link
Contributor

@jgbernalp: Jira Issue OCPBUGS-62276: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-62276 has been moved to the MODIFIED state.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@rexagod rexagod Awaiting requested review from rexagod

@slashpai slashpai Awaiting requested review from slashpai

@danielmellado danielmellado Awaiting requested review from danielmellado

@jan--f jan--f Awaiting requested review from jan--f

Assignees

@simonpasquier simonpasquier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgbernalp @openshift-ci-robot @simonpasquier @juzhao