Skip to content

[release-4.20] OCPBUGS-62829: Remove cluster from non-multicluster dashboards #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.20
Choose a base branch
from
Open

[release-4.20] OCPBUGS-62829: Remove cluster from non-multicluster dashboards #2701

wants to merge 2 commits into from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Oct 8, 2025 •
edited
Loading

Manual backport of OCPBUGS-61661

Remove the cluster variable to prevent accidentally filling it with .+ which breaks the dashboards.

Fixes OCPBUGS-62829

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

mgencur added 2 commits October 8, 2025 10:55
@mgencur
OCPBUGS-61661: Remove cluster from non-multicluster dashboards
bdcd0b2 
Remove the cluster variable to prevent accidentally filling it
with .+ which breaks the dashboards.

Fixes https://issues.redhat.com/browse/OCPBUGS-61661
@mgencur
OCPBUGS-62829: Remove dashboard generation from jsonnet and build pro…
021e799 
…cess

  The cluster-monitoring-operator no longer generates dashboards from
  jsonnet. This removes the entire dashboard generation pipeline including:
  - Dashboard ConfigMap generation logic from build-jsonnet.sh
  - dashboards.libsonnet component with 184 lines of dashboard processing
  - Dashboard integration from main.jsonnet

  The dashboards manifest (0000_90_cluster-monitoring-operator_01-dashboards.yaml)
  is now maintained manually, as indicated by the added comment.
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 8, 2025
@openshift-ci-robot
Copy link
Contributor

@mgencur: This pull request references Jira Issue OCPBUGS-62829, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual backport of OCPBUGS-61661

Remove the cluster variable to prevent accidentally filling it with .+ which breaks the dashboards.

Fixes OCPBUGS-62829

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mgencur
Copy link
Contributor Author

mgencur commented Oct 8, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mgencur: This pull request references Jira Issue OCPBUGS-62829, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rexagod and slashpai October 8, 2025 09:39
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign marioferh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Oct 8, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 8, 2025
@openshift-ci-robot
Copy link
Contributor

@mgencur: This pull request references Jira Issue OCPBUGS-62829, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-61661 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-61661 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from juzhao October 8, 2025 09:40
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 021e799 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rexagod rexagod Awaiting requested review from rexagod

@slashpai slashpai Awaiting requested review from slashpai

@juzhao juzhao Awaiting requested review from juzhao

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgencur @openshift-ci-robot