[WIP] MON-4380: Add optional monitoring logic #2688
Conversation
Optional components include: * Alertmanager * AlertmanagerUWM * ClusterMonitoringOperatorDeps (partially, for AM) * MonitoringPlugin * PromtheusOperator (partially, for AM) * PromtheusOperatorUWM * ThanosRuler Signed-off-by: Pranshu Srivastava <[email protected]>
|
@rexagod: This pull request references MON-4380 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| } | ||
|
|
||
| func (c *Client) HasOptionalMonitoringCapability(_ context.Context) (bool, error) { | ||
| //return c.HasClusterCapability(ctx, configv1.ClusterVersionCapabilityOptionalMonitoring) |
|
Also, this needs logic to drop existing optional workloads from the cluster, when the capability is enabled. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rexagod
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@rexagod: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Speaking out loud but wouldn't it be possible for the operator to look at the capability.openshift.io/name annotation on each managed resource and skip the action if it's marked as OptionalMonitoring and the capability is actually disabled? This way we wouldn't have to change the tasks orchestration.
|
/close Moving all raised comments and patches to #2675 |
|
@rexagod: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Optional components include: