OCPBUGS-43919: desiredWildcardDNSRecord: Check for nil LB field #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
jira/severity-moderate
|
@Miciah: This pull request references Jira Issue OCPBUGS-43919, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: This pull request references Jira Issue OCPBUGS-43919, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This commit fixes OCPBUGS-43919. https://issues.redhat.com/browse/OCPBUGS-43919 Follow-up to commit 5c36287. * pkg/resources/dnsrecord/dns.go (desiredWildcardDNSRecord): Check for a nil endpointPublishingStrategy.loadBalancer field. * pkg/resources/dnsrecord/dns_test.go (Test_desiredWildcardDNSRecord): Add a test case with a nil loadBalancer field.
Miciah
force-pushed
the
OCPBUGS-43919-desiredWildcardDNSRecord-check-for-nil-loadBalancer-field
branch
from
0607aa8 to
a05b6a0
Compare
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @Miciah i tested this PR using the cluster bot and here is the result. i can still see the panic message |
|
Also i can the issues metioned in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the
endpointPublishingStrategy.loadBalancerfield is nil indesiredWildcardDNSRecordto avoid potentially dereferencing a nil pointer and panicking.Follow-up to #781.