UPSTREAM: 5532: Azure Stack Fork #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds AzureStack as a valid cloud environment. The value "HybridEnvironment" is the value provided by the Azure autorest package. It would be possible to have a different user-facing value, such as AzureStackCloud, but internally within the code it is necessary to check for the value "HybridEnvironment" returned by autorest. This commit opts to use a single value, rather than separate user-facing and internal values.
Adds the ARMEndpoint field for specifying the ARM Resource Manager Endpoint for use with Azure Stack deployments. The endpoint is used to configure the environment as well as manage resources.
Uses ARMEndpoint from Cluster scope to configure Azure Stack settings for Azure Client and Authorizer, which will be used to configure ARM options for the V2 SDK.
Sets ARM Client Options when using the Azure Stack environment. Extends ARMClientOptions to accept an ARMEndpoint, which can be obtained from the authorizer interface, the same source the cloud environment. Sets the APIVersion to a hybrid cloud profile to ensure compatibility with hybrid environments.
Azure Stack Hub does not support private dns zones, so skip them.
The Resource SKU API for availability sets may not be available in an Azure Stack environment. The cache is used to determine the fault domain count. For Azure Stack, we can default to 2. Future work could potentially set this programatically or expose the fault domain count in the API.
The tag service using the V2 SDK is not available in azure stack. Skip tag reconciliation in Azure Stack environments.
The standard 2020-06-01 API Version is not supported for disk operations in Azure Stack, so change to the compatible 2018-06-01 profile.
Azure Stack returns a 400 error when trying to delete a VM with the force flag and the error message suggests retrying without the flag.
patrickdillon
force-pushed
the
openshift-ash-fork
branch
from
4605c9e to
02b0259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a fork for upstream azurestack support.
Pull Request: kubernetes-sigs#5532
Issue: kubernetes-sigs#5201
Once that PR is merged, we can remove this fork and just use upstream.