Replaced hardcoded branch names #4784
Conversation
openshift-ci
bot
added
the
approved
|
/test images |
|
/override ci/prow/breaking-changes ci/prow/lint |
|
@hector-vido: Overrode contexts on behalf of hector-vido: ci/prow/breaking-changes, ci/prow/lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test lint |
| args: | ||
| - --repo=https://github.com/openshift/release.git | ||
| - --branch=master | ||
| - --branch=${RELEASE_BRANCH} |
There was a problem hiding this comment.
I don't think this will work. Will oc command resolve that var from the env vars?
There was a problem hiding this comment.
This is an Openshift Template Variable/Parameter defined on line 227 of the Makefile and used as an argument on oc with -p RELEASE_BRANCH=$(RELEASE_BRANCH)
hector-vido
force-pushed
the
pr-deploy-default-branch
branch
from
0a5d36c to
55b60e5
Compare
|
/lgtm |
|
Scheduling required tests: Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, hector-vido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hector-vido: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 4fca181
into
openshift:main
3 participants
No description provided.