Skip to content

Conversation

@deepsm007
Copy link
Contributor

Follow up of #4758
/cc @openshift/test-platform

@openshift-ci openshift-ci bot requested a review from a team October 16, 2025 15:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@deepsm007 deepsm007 force-pushed the feature-slackreporterconfig branch 3 times, most recently from 7f7acfb to 661b1f0 Compare October 16, 2025 16:21
@deepsm007 deepsm007 changed the title Fix to exclude creating slackreportconfig for excluded pattern WIP: Fix to exclude creating slackreportconfig for excluded pattern Oct 16, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@deepsm007 deepsm007 force-pushed the feature-slackreporterconfig branch from 661b1f0 to a8cbe7c Compare October 16, 2025 16:32
@deepsm007 deepsm007 force-pushed the feature-slackreporterconfig branch from a8cbe7c to cdbfe80 Compare October 17, 2025 20:05
@deepsm007 deepsm007 changed the title WIP: Fix to exclude creating slackreportconfig for excluded pattern Fix to exclude creating slackreportconfig for excluded pattern Oct 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@deepsm007
Copy link
Contributor Author

/ai pr_description

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

@deepsm007:
Add full‑job‑name based Slack config lookup and drop default merging

  • Introduce GetSlackReporterConfigForJobName that checks excluded_job_patterns against full job names and respects JobName/JobNamePatterns.
  • Update presubmit, postsubmit, periodic, and images generation to call this new method.
  • Remove legacy Slack config setting from jobbase.go; Slack is now configured per job during generation.
  • Add tests:
    • MergeDefaults now never merges SlackReporterConfigs.
    • Jobs excluded by patterns no longer get SlackReporterConfig.
  • Update fixtures to match new output.
  • No other behavior changes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2025

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes cdbfe80 link false /test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deepsm007
Copy link
Contributor Author

/test images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant