Skip to content

Conversation

@kasturinarra
Copy link

@kasturinarra kasturinarra commented Jun 25, 2025

This PR introduces a command in github like /pj-rehearse {tag-name} where {tag-name} could be something like TNF. That command would look up the relevant available TNF tests and try to schedule rehearsals of the ones that match.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2025
@openshift-ci openshift-ci bot requested review from hector-vido and psalajova June 25, 2025 17:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign prucek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasturinarra
Copy link
Author

/retest-required

@kasturinarra
Copy link
Author

/test breaking-changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2025

@kasturinarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes 991712b link false /test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@droslean
Copy link
Member

@kasturinarra Can you elaborate more? On the first look I don't think that this feature makes any sense for the rehearse plugin. This tool is not supposed to rehearse jobs provided by the user. Let's try to figure out what is needed first and how we can implement it.

@kasturinarra
Copy link
Author

@kasturinarra Can you elaborate more? On the first look I don't think that this feature makes any sense for the rehearse plugin. This tool is not supposed to rehearse jobs provided by the user. Let's try to figure out what is needed first and how we can implement it.

@droslean here is what i am trying to achieve using the PR here, Improve this by introducing a command in github like /pj-rehearse {tag-name} where {tag-name} could be something like TNF. That command would look up the relevant available TNF tests and try to schedule rehearsals of the ones that match.

@kasturinarra
Copy link
Author

@kasturinarra Can you elaborate more? On the first look I don't think that this feature makes any sense for the rehearse plugin. This tool is not supposed to rehearse jobs provided by the user. Let's try to figure out what is needed first and how we can implement it.

@droslean here is what i am trying to achieve using the PR here, Improve this by introducing a command in github like /pj-rehearse {tag-name} where {tag-name} could be something like TNF. That command would look up the relevant available TNF tests and try to schedule rehearsals of the ones that match.

@droslean I think there might be a misunderstanding about what this feature does. This is NOT about allowing users to rehearse arbitrary jobs.

The tag-based selection works WITHIN the existing rehearsal system:

  1. Existing flow: PR changes → Rehearsal intelligence determines affected jobs → User runs /pj-rehearse {specific-job-names}
  2. Enhanced flow: PR changes → Rehearsal intelligence determines affected jobs → User runs /pj-rehearse-by-tag {tag} → System filters affected jobs by tag

The key point is that we're only adding tag-based filtering to jobs that the rehearsal system has already determined are affected by the PR changes. We're not bypassing any existing safety mechanisms.

Problem we're solving: With 81k+ presubmit jobs, developers can't discover which tests are relevant to their changes. Tags like tnf, telco, storage help group related tests for better discoverability.

Example scenario:

  • Developer makes changes to telco-related code
  • Rehearsal system identifies 50 affected jobs
  • Instead of needing to know specific job names, developer can run /pj-rehearse-by-tag telco
  • System runs only the telco-tagged jobs from those 50 affected jobs

This maintains all existing safety while improving usability. Does this clarify the intent?

presubmits = rehearse.FilterPresubmitsByTag(presubmits, periodicSlice, s.tagConfig, tag)

if len(presubmits) > 0 {
prConfig, prRefs, presubmitsToRehearse, err := rc.SetupJobs(candidate, candidatePath, presubmits, nil, math.MaxInt, logger)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

math.MaxInt concerns us

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2025
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants