-
Notifications
You must be signed in to change notification settings - Fork 289
[WIP] - Add code to execute pre-submits by tag #4611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kasturinarra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/test breaking-changes |
|
@kasturinarra: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@kasturinarra Can you elaborate more? On the first look I don't think that this feature makes any sense for the rehearse plugin. This tool is not supposed to rehearse jobs provided by the user. Let's try to figure out what is needed first and how we can implement it. |
@droslean here is what i am trying to achieve using the PR here, Improve this by introducing a command in github like /pj-rehearse {tag-name} where {tag-name} could be something like TNF. That command would look up the relevant available TNF tests and try to schedule rehearsals of the ones that match. |
@droslean I think there might be a misunderstanding about what this feature does. This is NOT about allowing users to rehearse arbitrary jobs. The tag-based selection works WITHIN the existing rehearsal system:
The key point is that we're only adding tag-based filtering to jobs that the rehearsal system has already determined are affected by the PR changes. We're not bypassing any existing safety mechanisms. Problem we're solving: With 81k+ presubmit jobs, developers can't discover which tests are relevant to their changes. Tags like Example scenario:
This maintains all existing safety while improving usability. Does this clarify the intent? |
| presubmits = rehearse.FilterPresubmitsByTag(presubmits, periodicSlice, s.tagConfig, tag) | ||
|
|
||
| if len(presubmits) > 0 { | ||
| prConfig, prRefs, presubmitsToRehearse, err := rc.SetupJobs(candidate, candidatePath, presubmits, nil, math.MaxInt, logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
math.MaxInt concerns us
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
This PR introduces a command in github like /pj-rehearse {tag-name} where {tag-name} could be something like TNF. That command would look up the relevant available TNF tests and try to schedule rehearsals of the ones that match.