Resync 20240926 #231
Merged
Resync 20240926 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: googs1025 <[email protected]>
fix: add validation for pggroup
- Add linux/ppc64le,linux/s390x - Switch to distroless - Add support for podman Signed-off-by: Paul Bastide <[email protected]>
Add support for ppc64le and s390x architectures and distroless builds
fix buildx command in cloudbuild
…90x-linux/ppc64le
chore: fix EventsToRegister method comment
bump k8s dependencies to v1.30.4
use `/bin/kube-scheduler` and `/bin/controller` as the entrypoints of Dockerfiles
solve struct literal uses unkeyed fields
In order to improve the debuggability of the overreserve cache, we would like to 1. correlate the cache state being used with 2. the actions the resync loop is doing 3. infer in a easier way the current state of the cache This change aims to improve points 1 and 2, while also trying to make 3 easier in the future. We introduce the concept of "generation" which is an opaque monotonically increasing integer similar in spirit to the `resourceVersion` kube API field. Every time the internal state of the cache is updated, which happens only in the resync loop by design, we increment the generation. GetCachedNRTCopy will also return the generation of the data being used, so we have now an uniform way to correlate readers and writer of the cache, and we gain better visibility of the data being used. With verbose enough logging, using the generation is now easier (albeit admittedly still clunky) to reconstruct the chain of changes which lead to a given cache state, which was much harder previously. Similarly, there's now a clear way to learn which cache state was used to make a given scheduling decision, which was much harder before. The changes involve mostly logging; to avoid proliferation of return values, however, a trivial refactoring is done in `GetCachedNRTCopy`. A beneficial side effect is much improved documentation of the return values. Signed-off-by: Francesco Romani <[email protected]>
nrt: log: introduce and use "generation" for cache
* Fixes controller's Dockerfile casing * Fixes scheduler's Dockerfile casing When using the Makefile to build the images, a warning arises regarding the incosistent casing of the "FROM" and "as" keywords.
* KEP for PEAKS plugin Signed-off-by: Krishnasuri Narayanam <[email protected]> * changes to address the KEP review comments * fixing toc as review comments Signed-off-by: Krishnasuri Narayanam <[email protected]> --------- Signed-off-by: Krishnasuri Narayanam <[email protected]>
Signed-off-by: Francesco Romani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
key commit relevant for us: 0dae3ec |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resync against upstream master