Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNI] build: envtest: remove 'latest' floating tag refs #185

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ffromani
Copy link
Member

never use floating tags in the build system, not
even for CI tests. Always pin explicit versions.

never use floating tags in the build system, not
even for CI tests. Always pin explicit versions.

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci openshift-ci bot requested review from swatisehgal and yanirq April 16, 2024 12:03
Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@ffromani ffromani added cherry-pick-candidate Propose a cherry-pick to stable branches and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2024
@ffromani
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani merged commit 64edcdd into master Apr 16, 2024
6 of 7 checks passed
@ffromani ffromani deleted the drop-latest-tag branch April 16, 2024 12:24
@ffromani ffromani added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 16, 2024
@openshift-cherrypick-robot

@ffromani: new pull request created: #186

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherry-pick-candidate Propose a cherry-pick to stable branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants