nmstate: update create() and returns #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
requested review from
kononovn,
trewest,
achuzhoy,
cdvultur and
klaskosk
as code owners
sebrandon1
force-pushed
the
nmstate_return_consistency
branch
from
b09464f to
8398afd
Compare
sebrandon1
force-pushed
the
nmstate_return_consistency
branch
from
8398afd to
c1040b2
Compare
klaskosk
pushed a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Jan 10, 2025
klaskosk
pushed a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #848
Apparently I missed the
Validate()func when updating the returns. I also updated theCreate()to match the example scheme from @klaskosk.