nfd: adjust return consistency #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
nfd_return_consistency
branch
2 times, most recently
from
6097d55 to
56a8107
Compare
klaskosk
reviewed
Jan 3, 2025
sebrandon1
force-pushed
the
nfd_return_consistency
branch
4 times, most recently
from
65c8a84 to
322d45e
Compare
sebrandon1
force-pushed
the
nfd_return_consistency
branch
3 times, most recently
from
3302e73 to
5931524
Compare
sebrandon1
force-pushed
the
nfd_return_consistency
branch
from
5931524 to
b06e1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out from #355
I had to re-arrange the NewBuilder func to properly handle errors which then forced an adjustment of the unit test cases.