networkpolicy: adjust return consistency #846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
requested review from
kononovn,
trewest,
achuzhoy,
cdvultur and
klaskosk
as code owners
sebrandon1
force-pushed
the
networkpolicy_return_consistency
branch
from
b673a29 to
1ed2c94
Compare
klaskosk
reviewed
Jan 3, 2025
| @@ -126,10 +126,6 @@ func (builder *EgressRuleBuilder) WithOptions(options ...EgressAdditionalOptions | |||
| func (builder *EgressRuleBuilder) WithPeerPodSelector(podSelector metav1.LabelSelector) *EgressRuleBuilder { | |||
| glog.V(100).Infof("Adding peer pod selector %v to EgressRule", podSelector) | |||
|
|
|||
| if builder.errorMsg != "" { | |||
There was a problem hiding this comment.
I think we should be using validate instead of checking the errorMsg here and then we don't have to change the unit tests
sebrandon1
force-pushed
the
networkpolicy_return_consistency
branch
from
1ed2c94 to
5651a79
Compare
sebrandon1
force-pushed
the
networkpolicy_return_consistency
branch
from
5651a79 to
8cecaaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out from #355