Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nad: adjust return consistency #835

Merged
merged 1 commit into from
Dec 20, 2024
Merged

nad: adjust return consistency #835

merged 1 commit into from
Dec 20, 2024

Conversation

sebrandon1
Copy link
Collaborator

Broken out from #355

@sebrandon1 sebrandon1 requested a review from kononovn as a code owner December 17, 2024 22:49
@sebrandon1 sebrandon1 self-assigned this Dec 17, 2024
@sebrandon1 sebrandon1 force-pushed the nad_return_consistency branch from 8f9025e to 9d60f49 Compare December 19, 2024 16:52
klaskosk
klaskosk approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@klaskosk klaskosk merged commit f510767 into openshift-kni:main Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaskosk klaskosk klaskosk approved these changes

@kononovn kononovn Awaiting requested review from kononovn kononovn is a code owner

Assignees

@sebrandon1 sebrandon1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebrandon1 @klaskosk