Skip to content

use floats for "le" #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

Conversation

maschmid
Copy link
Contributor

In OpenShift 4.19

With Prometheus v3, the classic histogram's "le" and summary's "quantile" labels values will be floats.

per https://issues.redhat.com/browse/MON-4129

  • 🧹 Use floats in "le" label prometheus query

@openshift-ci openshift-ci bot requested review from creydr and dsimansk April 28, 2025 19:44
@maschmid
Copy link
Contributor Author

maschmid commented May 2, 2025

/retest serverless-ingress-136-on-pull-request

Copy link
Contributor

openshift-ci bot commented May 2, 2025

@maschmid: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-operator-e2e
/test 414-test-upgrade
/test 417-aws-ovn-images
/test 417-azure-images
/test 417-gcp-images
/test 417-hypershift-images
/test 417-images
/test 417-operator-e2e
/test 417-osd-images
/test 417-single-node-images
/test 417-test-upgrade
/test 417-vsphere-images
/test 418-images
/test 418-operator-e2e
/test 418-test-upgrade
/test ocp4.17-lp-rosa-classic-images
/test ocp4.18-lp-interop-images

The following commands are available to trigger optional jobs:

/test 414-kitchensink-e2e
/test 414-kitchensink-upgrade
/test 414-mesh-e2e
/test 414-mesh-upgrade
/test 414-test-soak
/test 414-ui-e2e
/test 414-upstream-e2e
/test 414-upstream-e2e-kafka
/test 417-kitchensink-e2e
/test 417-kitchensink-upgrade
/test 417-mesh-e2e
/test 417-mesh-upgrade
/test 417-test-soak
/test 417-ui-e2e
/test 417-upstream-e2e
/test 417-upstream-e2e-kafka
/test 418-kitchensink-e2e
/test 418-kitchensink-upgrade
/test 418-mesh-e2e
/test 418-mesh-upgrade
/test 418-test-soak
/test 418-ui-e2e
/test 418-upstream-e2e
/test 418-upstream-e2e-kafka

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-serverless-operator-main-417-aws-ovn-images
pull-ci-openshift-knative-serverless-operator-main-417-azure-images
pull-ci-openshift-knative-serverless-operator-main-417-gcp-images
pull-ci-openshift-knative-serverless-operator-main-417-hypershift-images
pull-ci-openshift-knative-serverless-operator-main-417-images
pull-ci-openshift-knative-serverless-operator-main-417-operator-e2e
pull-ci-openshift-knative-serverless-operator-main-417-osd-images
pull-ci-openshift-knative-serverless-operator-main-417-single-node-images
pull-ci-openshift-knative-serverless-operator-main-417-test-upgrade
pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e
pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e-kafka
pull-ci-openshift-knative-serverless-operator-main-417-vsphere-images
pull-ci-openshift-knative-serverless-operator-main-ocp4.17-lp-rosa-classic-images
pull-ci-openshift-knative-serverless-operator-main-ocp4.18-lp-interop-images

In response to this:

/retest serverless-ingress-136-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maschmid
Copy link
Contributor Author

maschmid commented May 2, 2025

/ok-to-test

@creydr
Copy link
Member

creydr commented May 2, 2025

/lgtm

Copy link
Contributor

openshift-ci bot commented May 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2025
Copy link
Contributor

openshift-ci bot commented May 2, 2025

@maschmid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-vsphere-images 831fa8c link true /test 417-vsphere-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 79c3fb8 and 2 for PR HEAD 831fa8c in total

@creydr
Copy link
Member

creydr commented May 2, 2025

Merging, as all of them passed already

@creydr creydr merged commit e809bbc into openshift-knative:main May 2, 2025
9 of 24 checks passed
@maschmid
Copy link
Contributor Author

maschmid commented Jun 5, 2025

/cherrypick release-1.36

@openshift-cherrypick-robot
Copy link
Contributor

@maschmid: new pull request created: #3718

In response to this:

/cherrypick release-1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants