Skip to content

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Jun 4, 2025

Updated the triggerCI and createSyncReleasePR functions to utilize text templates for generating CI messages and bodies. This change improves message formatting and error handling when parsing templates. The previous string formatting has been replaced with template execution, enhancing maintainability and readability.

Updated the triggerCI and createSyncReleasePR functions to utilize text templates for generating CI messages and bodies. This change improves message formatting and error handling when parsing templates. The previous string formatting has been replaced with template execution, enhancing maintainability and readability.
@openshift-ci openshift-ci bot requested review from dsimansk and pierDipi June 4, 2025 17:13
Copy link

openshift-ci bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhuss
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but please change the default as well:

TriggerCI: ":robot: Synchronize branch `%s` to " +
"`upstream/%s`",
TriggerCIBody: "This automated PR is to make sure the " +
"forked project's `%s` branch (forked upstream's `%s` branch) passes" +
" a CI.",

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants