Skip to content

Conversation

@elfosardo
Copy link
Contributor

The yum command has been deprecated some time ago, we should just use dnf to avoid future breakage.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2025
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2025

Hi @elfosardo. Thanks for your PR.

I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link
Contributor Author

/cc @tdomnesc @danmanor

@openshift-ci openshift-ci bot requested a review from tdomnesc March 27, 2025 10:20
@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2025

@elfosardo: GitHub didn't allow me to request PR reviews from the following users: danmanor.

Note that only openshift-eng members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tdomnesc @danmanor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andfasano
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2025
@andfasano
Copy link
Contributor

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2025

@andfasano: The following commands are available to trigger required jobs:

/test e2e-tests
/test images
/test unit

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-eng-ofcir-main-images
pull-ci-openshift-eng-ofcir-main-unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andfasano
Copy link
Contributor

/test e2e-tests

The yum command has been deprecated some time ago, we should just
use dnf to avoid future breakage.
@openshift-ci
Copy link

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@elfosardo
Copy link
Contributor Author

/test e2e-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants