Skip to content

MGMT-19346: Enable 4/5 CPN to Cluster Details Form - 2.14#2739

Merged
ammont82 merged 7 commits intoopenshift-assisted:releases/v2.14-cimfrom
ammont82:MGMT-19346-enable-4/5-CPN-cluster-2.14
Jan 14, 2025
Merged

MGMT-19346: Enable 4/5 CPN to Cluster Details Form - 2.14#2739
ammont82 merged 7 commits intoopenshift-assisted:releases/v2.14-cimfrom
ammont82:MGMT-19346-enable-4/5-CPN-cluster-2.14

Conversation

@ammont82
Copy link
Copy Markdown
Member

@ammont82 ammont82 commented Dec 24, 2024 •
edited
Loading

@ammont82 ammont82 requested a review from a team as a code owner December 24, 2024 11:35
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 24, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 24, 2024 •
edited by openshift-ci Bot
Loading

@ammont82: This pull request references MGMT-19346 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 24, 2024
@nirfarkas
Copy link
Copy Markdown
Contributor

nirfarkas commented Dec 24, 2024

screenshot please

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 24, 2024 •
edited by openshift-ci Bot
Loading

@ammont82: This pull request references MGMT-19346 which is a valid jira issue.

Details

In response to this:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nirfarkas
Copy link
Copy Markdown
Contributor

nirfarkas commented Dec 24, 2024

Don't we need a "?" with some explanation text?
https://www.figma.com/design/guqtmQ4b2vF94WqmMYYhSh/Assisted---Multiple-control-plane-nodes-support?node-id=0-3&t=f28RsFKpffpcy1MM-4

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 2, 2025 •
edited by openshift-ci Bot
Loading

@ammont82: This pull request references MGMT-19346 which is a valid jira issue.

Details

In response to this:

image

Related to stolostron/console#4146

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jgyselov
jgyselov requested changes Jan 3, 2025
View reviewed changes
Comment thread libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDetailsFormFields.tsx
Comment thread libs/ui-lib/lib/common/components/clusterWizard/clusterDetailsValidation.ts
Comment thread libs/ui-lib/lib/common/components/clusterConfiguration/ControlPlaneNodesDropdown.tsx Outdated
@ammont82 ammont82 force-pushed the MGMT-19346-enable-4/5-CPN-cluster-2.14 branch from 920ea1b to 88e17ff Compare January 8, 2025 14:09
@ammont82 ammont82 force-pushed the MGMT-19346-enable-4/5-CPN-cluster-2.14 branch from b17d614 to baeffdb Compare January 14, 2025 06:56
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 043f767 into openshift-assisted:releases/v2.14-cim Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgyselov jgyselov jgyselov approved these changes

Assignees

@jgyselov jgyselov

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ammont82 @openshift-ci-robot @nirfarkas @jgyselov