Skip to content

new ad create enhanced tool to validate and create multiple detectors #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amitgalitz wants to merge 8 commits into
base: main
Choose a base branch
from
Open

new ad create enhanced tool to validate and create multiple detectors #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6bf2317
new ad create enhanced tool to validate and create multiple detectors
amitgalitz Dec 1, 2025
6142400
add index insight integration with fallback
amitgalitz Apr 6, 2026
1f952c1
adding otel built in detectors
amitgalitz Apr 6, 2026
c79f5d4
code cleanup addressing several comments
amitgalitz Apr 7, 2026
3267746
adding sequential detector creation
amitgalitz Apr 9, 2026
e1a4c29
Add prompt filter support, custom result index, and sequential multi-…
amitgalitz Apr 13, 2026
e050efa
Production hardening: frequency jitter, null field filter, retry memory
amitgalitz Apr 13, 2026
272b101
Flexible LLM parser, OTel validation, input guards, prompt consolidat…
amitgalitz Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/opensearch/agent/ToolPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import org.opensearch.agent.tools.CreateAlertTool;
import org.opensearch.agent.tools.CreateAnomalyDetectorTool;
import org.opensearch.agent.tools.CreateAnomalyDetectorToolEnhanced;
import org.opensearch.agent.tools.DataDistributionTool;
import org.opensearch.agent.tools.LogPatternAnalysisTool;
import org.opensearch.agent.tools.LogPatternTool;
Expand Down Expand Up @@ -100,6 +101,7 @@ public Collection<Object> createComponents(
SearchMonitorsTool.Factory.getInstance().init(client);
CreateAlertTool.Factory.getInstance().init(client);
CreateAnomalyDetectorTool.Factory.getInstance().init(client);
CreateAnomalyDetectorToolEnhanced.Factory.getInstance().init(client, namedWriteableRegistry);
LogPatternTool.Factory.getInstance().init(client, xContentRegistry);
WebSearchTool.Factory.getInstance().init(threadPool);
LogPatternAnalysisTool.Factory.getInstance().init(client);
Expand All @@ -123,6 +125,7 @@ public List<Tool.Factory<? extends Tool>> getToolFactories() {
SearchMonitorsTool.Factory.getInstance(),
CreateAlertTool.Factory.getInstance(),
CreateAnomalyDetectorTool.Factory.getInstance(),
CreateAnomalyDetectorToolEnhanced.Factory.getInstance(),
LogPatternTool.Factory.getInstance(),
WebSearchTool.Factory.getInstance(),
LogPatternAnalysisTool.Factory.getInstance(),
Expand Down
20 changes: 4 additions & 16 deletions src/main/java/org/opensearch/agent/tools/CreateAnomalyDetectorTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import java.security.PrivilegedExceptionAction;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
import java.util.Map;
Expand Down Expand Up @@ -209,7 +208,7 @@ public <T> void run(Map<String, String> parameters, ActionListener<T> listener)
ToolHelper.extractFieldNamesTypes(mappingSource, fieldsToType, "", true);

// find all date type fields from the mapping
final Set<String> dateFields = findDateTypeFields(fieldsToType);
final Set<String> dateFields = ToolHelper.findDateTypeFields(fieldsToType);
if (dateFields.isEmpty()) {
throw new IllegalArgumentException(
"The index " + indexName + " doesn't have date type fields, cannot create an anomaly detector for it."
Expand All @@ -228,6 +227,8 @@ public <T> void run(Map<String, String> parameters, ActionListener<T> listener)

// construct the prompt
String prompt = constructPrompt(filteredMapping, firstIndexName);
log.info("Using prompt for anomaly detector creation (simple): {}", prompt);

RemoteInferenceInputDataSet inputDataSet = RemoteInferenceInputDataSet
.builder()
.parameters(Collections.singletonMap("prompt", prompt))
Expand Down Expand Up @@ -335,21 +336,8 @@ private Map<String, String> enrichParameters(Map<String, String> parameters) {

/**
*
* @param fieldsToType the flattened field-> field type mapping
* @return a list containing all the date type fields
*/
private Set<String> findDateTypeFields(final Map<String, String> fieldsToType) {
Set<String> result = new HashSet<>();
for (Map.Entry<String, String> entry : fieldsToType.entrySet()) {
String value = entry.getValue();
if (value.equals("date") || value.equals("date_nanos")) {
result.add(entry.getKey());
}
}
return result;
}

@SuppressWarnings("unchecked")
**/
Copy link
Copy Markdown
Collaborator

@kaituo kaituo Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuppressWarnings should be outside of comment block. This may cause CI compile failure.

private static Map<String, String> loadDefaultPromptFromFile() {
try (InputStream inputStream = CreateAnomalyDetectorTool.class.getResourceAsStream("CreateAnomalyDetectorDefaultPrompt.json")) {
if (inputStream != null) {
Expand Down
Loading
Loading