Skip to content

Conversation

@owaiskazi19
Copy link
Member

Description

Fix agent update

{
"error": {
  "root_cause": [
  {
  "type": "illegal_argument_exception",
  "reason": "Agent type cannot be updated"
  }
  ],
  "type": "illegal_argument_exception",
  "reason": "Agent type cannot be updated"
  },
  "status": 400
}

Related Issues

Resolves #4340

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
Copy link
Contributor

@rithin-pullela-aws rithin-pullela-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you rebase your main with current main? Looks like around 27 commits are pushed

@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Error
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Error
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Failure
Copy link
Collaborator

@pyek-bot pyek-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM, thanks for this!

@owaiskazi19 owaiskazi19 requested a review from pyek-bot October 23, 2025 17:28
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 17:29 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 17:29 — with GitHub Actions Error
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 17:29 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2025 06:55 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env-require-approval October 24, 2025 06:55 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env-require-approval October 24, 2025 06:55 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.12%. Comparing base (eec7179) to head (6b2dad5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ml/common/transport/agent/MLAgentUpdateInput.java 63.63% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4341      +/-   ##
============================================
- Coverage     80.13%   80.12%   -0.02%     
+ Complexity    10171    10162       -9     
============================================
  Files           854      854              
  Lines         44219    44230      +11     
  Branches       5113     5117       +4     
============================================
+ Hits          35437    35440       +3     
- Misses         6631     6637       +6     
- Partials       2151     2153       +2     
Flag Coverage Δ
ml-commons 80.12% <63.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pyek-bot
pyek-bot previously approved these changes Oct 27, 2025
@owaiskazi19 owaiskazi19 force-pushed the fix-agent-update branch 3 times, most recently from e54c320 to 5faab09 Compare November 10, 2025 18:48
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval November 10, 2025 18:51 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env-require-approval November 10, 2025 18:51 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval November 10, 2025 18:51 — with GitHub Actions Error
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env-require-approval November 10, 2025 18:51 — with GitHub Actions Inactive
@ylwu-amzn
Copy link
Collaborator

LGTM!

Can you rebase your main with current main? Looks like around 27 commits are pushed

Rebased directly on Github UI

@ylwu-amzn ylwu-amzn requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:04 — with GitHub Actions Waiting
@ylwu-amzn ylwu-amzn requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:04 — with GitHub Actions Waiting
@ylwu-amzn ylwu-amzn requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:04 — with GitHub Actions Waiting
@ylwu-amzn ylwu-amzn requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:04 — with GitHub Actions Waiting
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:40 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:40 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:40 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval November 20, 2025 18:40 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Update agent API silently fails when changing agent type

5 participants