make MLSdkAsyncHttpResponseHandler return IllegalArgumentException #4182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Flores <[email protected]>
brianf-aws
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman,
xinyual and
pyek-bot
as code owners
jiapingzeng
approved these changes
Sep 18, 2025
brianf-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
brianf-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
brianf-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
brianf-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
Zhangxunmt
approved these changes
Sep 18, 2025
pyek-bot
approved these changes
Sep 18, 2025
dhrubo-os
reviewed
Sep 18, 2025
| ModelTensors tensors = processOutput(action, body, connector, scriptService, parameters, mlGuard); | ||
| tensors.setStatusCode(statusCode); | ||
| actionListener.onResponse(new Tuple<>(executionContext.getSequence(), tensors)); | ||
| } catch (IllegalArgumentException e) { |
There was a problem hiding this comment.
Can we also try to catch the OpensearchStatus Exception too in another catch block?
There was a problem hiding this comment.
Ah good catch would need to look what scenarios cause a OpensearchStatus to occur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a mitigation for #4170
But would need a more thorough code change so that clients can handle properly all situations.
Related Issues
#4170 can be closed but discussion can be done to consider different types of failures
Testing
./gradlew spotlessApply
./gradlew test
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.