Use optionalField for creation in ExplainSMPolicy serialization

[Tarun-kishore]

Description

Fixed incorrect serialization of the creation field in ExplainSMPolicy.toXContent(). The method was using .field() instead of .optionalField() for the nullable creation field, which is inconsistent with how the deletion field is handled and with the reference implementation in SMMetadata.toXContent().

Changed line 39 in ExplainSMPolicy.kt:

• Before: .field(SMMetadata.CREATION_FIELD, it.creation)
• After: .optionalField(SMMetadata.CREATION_FIELD, it.creation)

This ensures proper handling of null creation workflow metadata in Explain API responses and aligns with the serialization behavior in SMMetadata.

Related Issues

Resolves #1506

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Hailong-am]

will this have bwc issue when doing rolling upgrade? guess we need to add version check here

[Tarun-kishore]

Yes, Good catch. Added a version check.

[Tarun-kishore]

@Hailong-am I added a version check for greater than 3.3 (which is current version). The coverage is failing though, version 3.4 needs to be available for testing it. Rest all CI workflows are passing.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.37%. Comparing base (3cf62f0) to head (ae99a59).

Files with missing lines	Patch %	Lines
...gement/snapshotmanagement/model/ExplainSMPolicy.kt	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   76.47%   76.37%   -0.11%     
==========================================
  Files         375      375              
  Lines       18835    18838       +3     
  Branches     2401     2402       +1     
==========================================
- Hits        14405    14388      -17     
- Misses       3182     3206      +24     
+ Partials     1248     1244       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bowenlan-amzn]

Could you add a test covering this?

[Tarun-kishore]

I've added unit test covering the parsing, but unit test cannot change Version.Current value. I can add a method like getCurrentVersion and mock that but that doesn't seem like a good way. I've also updated bwc tests to get explain response, Seems like it's coverage isn't included in coverage check.
I've update version check to onOrAfter V.3_3_0 to test bwc coverage, once V.3_4_0 is available I'll update it to that.