fix(test): replace hardcoded waits with API intercepts in edit tests#757
Open
sumukhswamy wants to merge 2 commits into
Open
fix(test): replace hardcoded waits with API intercepts in edit tests#757sumukhswamy wants to merge 2 commits into
sumukhswamy wants to merge 2 commits into
Conversation
sumukhswamy
requested review from
Swiddis,
TackAdam,
anirudha,
dai-chen,
joshuali925,
mengweieric,
penghuo,
ps48 and
vamsimanohar
as code owners
sumukhswamy
force-pushed
the
fix/flaky-edit-tests
branch
from
19f2710 to
25db867
Compare
sumukhswamy
force-pushed
the
fix/flaky-edit-tests
branch
6 times, most recently
from
44d3b39 to
847a9cf
Compare
…tests Replace flaky cy.wait(12500) calls with Cypress retryable assertions. Use beforeEach to navigate and wait for #reportDefinitionDetailsLink with a 60s timeout, ensuring the report list is populated before each test attempts to interact with it. Added retry with reload to handle index refresh delays between tests. Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
CVE-2026-41907 (Critical, CVSS 9.8): uuid@8.3.2 via exceljs - exceljs requires uuid@^8.3.0, max available is 8.3.2 (vulnerable) - No fix exists within the ^8.x range - Added yarn resolution to force uuid@^11.1.1 (lowest fixed version) CVE-2026-44705 (High, CVSS 7.5): tmp@0.2.5 via exceljs - exceljs requires tmp@^0.2.0, fix available in 0.2.6+ - Removed yarn.lock entry to allow resolution to latest 0.2.x Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
force-pushed
the
fix/flaky-edit-tests
branch
from
847a9cf to
0bcdfcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace flaky cy.wait(12500) calls with cy.intercept/cy.wait for the reportDefinitions API and add explicit 60s timeouts on element assertions. This prevents race conditions where the report list hasn't loaded before the test tries to click #reportDefinitionDetailsLink.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.