Chatbot entry UI redesign #396
Merged
+129
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
raintygao
as code owners
SuZhou-Joe
reviewed
Jan 22, 2025
public/index.scss
Outdated
Comment on lines
23
to
27
| @media (max-width: 1200px) { | ||
| &.in-singleline-header{ | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: seems we can leverage https://oui.opensearch.org/1.19/#/utilities/css-utility-classes#responsive .
SuZhou-Joe
reviewed
Jan 22, 2025
| display: flex; | ||
| align-items: center; | ||
| position: relative; | ||
| width: 200px; |
There was a problem hiding this comment.
Do you mean it should be shrink in small screens?
There was a problem hiding this comment.
I don't know, in terms of responsive I thought max-width would be more suitable. But I do not have much context on this style.
There was a problem hiding this comment.
Let me leave a comment to UX team. There is no related responsive design for screen width 1200px.
SuZhou-Joe
approved these changes
Jan 22, 2025
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
wanglam
changed the title
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.x
# Create a new branch
git switch --create backport/backport-396-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b5d0df6ee50ac374f6eefd7821284b49acac7699
# Push it to GitHub
git push --set-upstream origin backport/backport-396-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.xThen, create a pull request where the |
wanglam
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Chatbot entry UI redesign Signed-off-by: Lin Wang <[email protected]> * Add changelog for chatbot entry redesign Signed-off-by: Lin Wang <[email protected]> * Fix failed UTs Signed-off-by: Lin Wang <[email protected]> * Use unified responsive breakpoints Signed-off-by: Lin Wang <[email protected]> * Change to use registerHeaderRight Signed-off-by: Lin Wang <[email protected]> * Change to use registerPrimaryHeaderRight Signed-off-by: Lin Wang <[email protected]> * Show graident icon when focus Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit b5d0df6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
wanglam
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Chatbot entry UI redesign Signed-off-by: Lin Wang <[email protected]> * Add changelog for chatbot entry redesign Signed-off-by: Lin Wang <[email protected]> * Fix failed UTs Signed-off-by: Lin Wang <[email protected]> * Use unified responsive breakpoints Signed-off-by: Lin Wang <[email protected]> * Change to use registerHeaderRight Signed-off-by: Lin Wang <[email protected]> * Change to use registerPrimaryHeaderRight Signed-off-by: Lin Wang <[email protected]> * Show graident icon when focus Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit b5d0df6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hutiechuan
pushed a commit
to hutiechuan/dashboards-assistant
that referenced
this pull request
Jan 24, 2025
* Chatbot entry UI redesign Signed-off-by: Lin Wang <[email protected]> * Add changelog for chatbot entry redesign Signed-off-by: Lin Wang <[email protected]> * Fix failed UTs Signed-off-by: Lin Wang <[email protected]> * Use unified responsive breakpoints Signed-off-by: Lin Wang <[email protected]> * Change to use registerHeaderRight Signed-off-by: Lin Wang <[email protected]> * Change to use registerPrimaryHeaderRight Signed-off-by: Lin Wang <[email protected]> * Show graident icon when focus Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for redesign the chatbot entry according the latest UI design. This PR using a new nav control slot which not been merged in OSD.
The chatbot entry will be a button icon when screen width less than 1200 and in application header.
Screenshots
application header greater and equal 1200
application header less than 1200
In normal header
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.