Skip to content

Conversation

@karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Sep 24, 2025

Description

  1. Implement Exists, Regexp, Wildcard queries for GRPC.
  2. Small fix to make all *ProtoUtils.java classes package private.

Related Issues

Partially resolves #18907

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Sep 24, 2025
@karenyrx karenyrx changed the title [GRPC][Term-level queries] Implement Exists, Ids, Regexp, Wildcard queries [GRPC][Term-level queries] Add Exists, Ids, Regexp, and Wildcard queries Sep 24, 2025
Signed-off-by: karenx <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 6200124: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx karenyrx changed the title [GRPC][Term-level queries] Add Exists, Ids, Regexp, and Wildcard queries [GRPC][Term-level queries] Add Exists, Regexp, and Wildcard queries Sep 29, 2025
@karenyrx karenyrx force-pushed the morequerytypes branch 2 times, most recently from 02e7bfe to 876db21 Compare September 29, 2025 04:57
Signed-off-by: Karen X <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 143b615: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx karenyrx closed this Sep 29, 2025
@karenyrx karenyrx reopened this Sep 29, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 143b615: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx karenyrx closed this Sep 29, 2025
@karenyrx karenyrx reopened this Sep 29, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 143b615: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen X <[email protected]>
@karenyrx karenyrx marked this pull request as ready for review September 29, 2025 18:01
@karenyrx karenyrx requested a review from a team as a code owner September 29, 2025 18:01
@github-actions
Copy link
Contributor

❌ Gradle check result for d494f09: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for ac26ac5: SUCCESS

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.96%. Comparing base (2c6a404) to head (e393921).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main   #19392    +/-   ##
==========================================
  Coverage     72.95%   72.96%            
- Complexity    70115    70159    +44     
==========================================
  Files          5687     5695     +8     
  Lines        321703   321887   +184     
  Branches      46534    46565    +31     
==========================================
+ Hits         234702   234864   +162     
+ Misses        68074    68073     -1     
- Partials      18927    18950    +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Karen X <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 2f81856: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen X <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 4bf9666: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 21208ce: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions
Copy link
Contributor

✅ Gradle check result for e393921: SUCCESS

@mch2 mch2 merged commit 75fd8a6 into opensearch-project:main Sep 30, 2025
36 of 37 checks passed
asimmahmood1 pushed a commit to asimmahmood1/OpenSearch that referenced this pull request Sep 30, 2025
…pensearch-project#19392)

* [GRPC] Implement Exists, Ids, Regexp, Wildcard queries

Signed-off-by: karenx <[email protected]>

* changelog

Signed-off-by: karenx <[email protected]>

* remove idsquery

Signed-off-by: Karen X <[email protected]>

* package private

Signed-off-by: Karen X <[email protected]>

* compile with 0.18.0 protos

Signed-off-by: Karen X <[email protected]>

* spotlessApply

Signed-off-by: Karen X <[email protected]>

* add tests

Signed-off-by: Karen X <[email protected]>

* spotless

Signed-off-by: Karen X <[email protected]>

---------

Signed-off-by: karenx <[email protected]>
Signed-off-by: Karen X <[email protected]>
Co-authored-by: karenx <[email protected]>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…pensearch-project#19392)

* [GRPC] Implement Exists, Ids, Regexp, Wildcard queries

Signed-off-by: karenx <[email protected]>

* changelog

Signed-off-by: karenx <[email protected]>

* remove idsquery

Signed-off-by: Karen X <[email protected]>

* package private

Signed-off-by: Karen X <[email protected]>

* compile with 0.18.0 protos

Signed-off-by: Karen X <[email protected]>

* spotlessApply

Signed-off-by: Karen X <[email protected]>

* add tests

Signed-off-by: Karen X <[email protected]>

* spotless

Signed-off-by: Karen X <[email protected]>

---------

Signed-off-by: karenx <[email protected]>
Signed-off-by: Karen X <[email protected]>
Co-authored-by: karenx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] [GRPC][Search] Implement Term-level Query Proto Converters

2 participants