-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[GRPC][Compound queries] Implement Boolean query and inject registry for all built-in query converters #19391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onverters Signed-off-by: karenx <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19391 +/- ##
============================================
+ Coverage 72.90% 73.00% +0.10%
- Complexity 70014 70072 +58
============================================
Files 5681 5683 +2
Lines 321457 321523 +66
Branches 46486 46500 +14
============================================
+ Hits 234347 234717 +370
+ Misses 68187 67868 -319
- Partials 18923 18938 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
|
❌ Gradle check result for 415a4e0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 415a4e0: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen X <[email protected]>
|
❌ Gradle check result for 99a5987: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen X <[email protected]>
|
❌ Gradle check result for 93813d6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Unrelated test failure |
...ava/org/opensearch/transport/grpc/proto/request/search/query/BoolQueryBuilderProtoUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
|
❕ Gradle check result for 550904b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…for all built-in query converters (opensearch-project#19391) * [GRPC] Implement Boolean query and inject registry for all internal converters Signed-off-by: karenx <[email protected]> * update CHANGELOG Signed-off-by: Karen X <[email protected]> * delete extra file Signed-off-by: Karen X <[email protected]> * remove dead code and update tests Signed-off-by: Karen X <[email protected]> * pakcage private Signed-off-by: Karen X <[email protected]> * spotless and compile Signed-off-by: Karen X <[email protected]> * pass registry instead of making it static Signed-off-by: Karen X <[email protected]> --------- Signed-off-by: karenx <[email protected]> Signed-off-by: Karen X <[email protected]> Co-authored-by: karenx <[email protected]>
Description
Implement GRPC boolean query.
Since boolean query is a query type which can take in other query types, it needs access to the internal query registry, so this PR also adds a mechanism to loop through all registered built-in query converters (i.e. those implemented in core, and not in an extenral plugin), to inject the registry into them.
Test Plan
Started a local opensearch cluster and run a bool query, with a term/terms/matchall query inside:
Related Issues
Resolves #19390
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.