Skip to content

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Sep 23, 2025

Description

While researching opensearch-project/opensearch-build#5720, I ran into an issue where I could not version bump the core to 3.3.1 and run ./gradlew localDistro successfully. It would run into the following error:

* What went wrong:
An exception occurred applying plugin request [id: 'opensearch.global-build-info']
> Failed to apply plugin 'opensearch.global-build-info'.
   > Expected exactly 2 majors in parsed versions but found: [2, 3, 6, 7]

The reason for this is that it hit this block which is only triggered when the minor and patch version are both non-zero. When the patch number is 0 (as it is with any minor version bump) then the condition never gets triggered.

This PR resolves the issue by removing references to the Legacy ES version numbers which are more than 2 major versions in the past at this point.

Related Issues

Related to opensearch-project/opensearch-build#5720

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team as a code owner September 23, 2025 15:29
Signed-off-by: Craig Perkins <[email protected]>
Copy link
Contributor

✅ Gradle check result for be0a4b5: SUCCESS

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (a132bb5) to head (891235b).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../opensearch/gradle/info/GlobalBuildInfoPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19377      +/-   ##
============================================
+ Coverage     72.81%   72.94%   +0.13%     
- Complexity    69838    69849      +11     
============================================
  Files          5674     5674              
  Lines        320850   320861      +11     
  Branches      46383    46386       +3     
============================================
+ Hits         233624   234058     +434     
+ Misses        68361    67869     -492     
- Partials      18865    18934      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

❌ Gradle check result for 891235b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 891235b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant