Fix bug "Assertion framework(Yaml Rest test): numeric comparison fails when comparing Integer vs Long (or Float vs Double)"

[laminelam]

Resolves #19323

The numerical comparison classes (gt, gte, lt and lte) share more than 90% of the code. Refactored the 4 classes by extracted the common code into a super class.

Updated the convertActualValue method to normalize mixed numeric types to a common upper type.

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for e258963: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[laminelam]

Hi @sandeshkr419
Can you, or somebody else look at this?

[sandeshkr419]

Thanks for fixing this and refactoring the code. I do have some clarifying questions.

[github-actions]

❌ Gradle check result for 596a2b6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[andrross]

@sandeshkr419 Can you take another look at this?

[github-actions]

❌ Gradle check result for 596a2b6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 596a2b6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 3ca23d2: SUCCESS

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.16%. Comparing base (3ffa49a) to head (3ca23d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19376      +/-   ##
============================================
+ Coverage     73.07%   73.16%   +0.09%     
- Complexity    70741    70858     +117     
============================================
  Files          5732     5732              
  Lines        324140   324140              
  Branches      46922    46922              
============================================
+ Hits         236853   237169     +316     
+ Misses        68117    67858     -259     
+ Partials      19170    19113      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.