Skip to content

Conversation

@bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Sep 23, 2025

Description

This PR changes the way to enable stream search feature.
Previously it's through query param, now change to a feature flag.

If enable stream transport and search feature flag at the same time, user can try out the stream search feature. Example gradle run command below.

./gradlew run -PinstalledPlugins="['arrow-flight-rpc']" \
-Dtests.opensearch.opensearch.experimental.feature.transport.stream.enabled=true \
-Dtests.opensearch.opensearch.experimental.feature.stream.search.enabled=true
  • The auto fallback logic still pending. We need to understand what search and aggregation are supported.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 90ccce3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for bb3e8e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for bb3e8e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 3cb08c3: SUCCESS

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.98%. Comparing base (2c6a404) to head (a74ef16).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...pensearch/rest/action/search/RestSearchAction.java 64.28% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19373      +/-   ##
============================================
+ Coverage     72.95%   72.98%   +0.03%     
- Complexity    70115    70123       +8     
============================================
  Files          5687     5688       +1     
  Lines        321703   321804     +101     
  Branches      46534    46550      +16     
============================================
+ Hits         234702   234883     +181     
+ Misses        68074    67917     -157     
- Partials      18927    19004      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review September 25, 2025 11:22
@bowenlan-amzn bowenlan-amzn requested a review from a team as a code owner September 25, 2025 11:22
@github-actions
Copy link
Contributor

❌ Gradle check result for 1fc5227: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rishabhmaurya
Copy link
Contributor

@bowenlan-amzn looks good, couple of minor comments.

@github-actions
Copy link
Contributor

❌ Gradle check result for 4ece007: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 8d53534: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 8d53534: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions
Copy link
Contributor

❕ Gradle check result for a74ef16: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@rishabhmaurya rishabhmaurya merged commit 51a091b into opensearch-project:main Sep 30, 2025
32 of 33 checks passed
asimmahmood1 pushed a commit to asimmahmood1/OpenSearch that referenced this pull request Sep 30, 2025
…oject#19373)

* Use feature flag instead of query param

Signed-off-by: bowenlan-amzn <[email protected]>

* add tests

Signed-off-by: bowenlan-amzn <[email protected]>

* add changelog

Signed-off-by: bowenlan-amzn <[email protected]>

* Disable stream search for normal search

Signed-off-by: bowenlan-amzn <[email protected]>

* Address comment

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: Rishabh Maurya <[email protected]>
Co-authored-by: Rishabh Maurya <[email protected]>
@bowenlan-amzn bowenlan-amzn deleted the auto-fallback branch October 1, 2025 00:24
@rishabhmaurya
Copy link
Contributor

@bowenlan-amzn on thinking more about this feature flag, it makes more sense to me to have it as a dynamic cluster setting with default as off. Let me know what do you think?
cc @harshavamsi

@rishabhmaurya rishabhmaurya moved this from Todo to Done in Performance Roadmap Oct 3, 2025
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…oject#19373)

* Use feature flag instead of query param

Signed-off-by: bowenlan-amzn <[email protected]>

* add tests

Signed-off-by: bowenlan-amzn <[email protected]>

* add changelog

Signed-off-by: bowenlan-amzn <[email protected]>

* Disable stream search for normal search

Signed-off-by: bowenlan-amzn <[email protected]>

* Address comment

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: Rishabh Maurya <[email protected]>
Co-authored-by: Rishabh Maurya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants