[Pull-based ingestion] Support multi-threaded writes in pull based ingestion #17912
+564
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
varunbharadwaj
force-pushed
the
vb/multithreadwrite
branch
3 times, most recently
from
c697e54 to
ec2b1ed
Compare
Signed-off-by: Varun Bharadwaj <[email protected]>
varunbharadwaj
force-pushed
the
vb/multithreadwrite
branch
from
ec2b1ed to
bd15ddb
Compare
|
❌ Gradle check result for bd15ddb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multi-threaded writer support in the pull-based ingestion flow. The incoming message will be hashed by ID and written to one of the blocking queue partitions. A processor thread will be started to consume and process updates from each blocking queue partition. This thread will handoff the updates to the engine to update the index.
Number of processor threads can be defined at the time of index creation by setting ingestion_source.num_processor_threads. If not set, a default value of 1 will be used.During shard recovery, the minimum shard pointer tracked across processor threads will be used the the start point.
Related Issues
Resolves #17875
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.