Skip to content

[Rule based auto tagging] Add WLM action filter to automate tagging for search traffic #17791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

[Rule based auto tagging] Add WLM action filter to automate tagging for search traffic #17791

wants to merge 31 commits into from
+224 −0

Conversation

kaushalmahi12
Copy link
Contributor

Description

With this change we can automatically tag the search traffic with appropriate queryGroupId based on predefined Rules. Until now we were relying on HTTP header based approach to supply this value but now this process will be automated. ActionFilters are invoked at Transport layer which is upstream to the consumption of this information.

Related Issues

https://github.com/opensearch-project/OpenSearch/issues/16797#issuecomment-2594284060>
#13341

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kaushalmahi12
[rule based autotagging] add attribute value store
739c6e6 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add CHANGELOG entry
037b697 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add in-memory rule processing service
0a4f764 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add missing javadoc
3618933 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
merge the in-memory store changes:
874072d 
commit d02e544
Author: Kaushal Kumar <[email protected]>
Date:   Mon Feb 17 13:05:20 2025 -0800

    add licenses directory

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 3f98f9d
Author: Kaushal Kumar <[email protected]>
Date:   Mon Feb 17 11:52:56 2025 -0800

    improve binary search bisecting expression

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 630a3ee
Author: Kaushal Kumar <[email protected]>
Date:   Mon Feb 17 11:14:39 2025 -0800

    improve javadoc for attribute value store

    Signed-off-by: Kaushal Kumar <[email protected]>

commit acdb27c
Author: Kaushal Kumar <[email protected]>
Date:   Fri Feb 14 10:09:58 2025 -0800

    add missing javadoc

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 24c4ea6
Author: Kaushal Kumar <[email protected]>
Date:   Fri Feb 14 09:28:46 2025 -0800

    run spotless apply

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 75b6e68
Author: Kaushal Kumar <[email protected]>
Date:   Fri Feb 14 09:24:32 2025 -0800

    make the store interface generic

    Signed-off-by: Kaushal Kumar <[email protected]>

Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
fix generics error
447cc54 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add auto tagging ActionFilter
0b391b3 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add action filter unit tests
785523a 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
[rule based autotagging] add attribute value store
a186749 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add in-memory rule processing service
5c6d37f 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add missing javadoc
5f33006 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
merge the in-memory store changes:
daff632 
commit d02e544
Author: Kaushal Kumar <[email protected]>
Date:   Mon Feb 17 13:05:20 2025 -0800

    add licenses directory

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 3f98f9d
Author: Kaushal Kumar <[email protected]>
Date:   Mon Feb 17 11:52:56 2025 -0800

    improve binary search bisecting expression

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 630a3ee
Author: Kaushal Kumar <[email protected]>
Date:   Mon Feb 17 11:14:39 2025 -0800

    improve javadoc for attribute value store

    Signed-off-by: Kaushal Kumar <[email protected]>

commit acdb27c
Author: Kaushal Kumar <[email protected]>
Date:   Fri Feb 14 10:09:58 2025 -0800

    add missing javadoc

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 24c4ea6
Author: Kaushal Kumar <[email protected]>
Date:   Fri Feb 14 09:28:46 2025 -0800

    run spotless apply

    Signed-off-by: Kaushal Kumar <[email protected]>

commit 75b6e68
Author: Kaushal Kumar <[email protected]>
Date:   Fri Feb 14 09:24:32 2025 -0800

    make the store interface generic

    Signed-off-by: Kaushal Kumar <[email protected]>

Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
fix generics error
e5c98fe 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add CHANGELOG entry
c5b2766 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
remove stubs
5d59a72 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
move generic logic to lib
a7e9de7 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
fix javadoc error
6eb15f5 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
fix javadoc error
4b43025 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
delete licenses from the wlm plugin
b7de765 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
expose feature level attribute value store init method
f6bae1d 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
add extra space to remove unwanted entry from the changelog diff
0ad6a09 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
address comments
1e90840 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
use constructors over static methods
627efa6 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
make member var final in InMemoryRuleProcessingService
e502a38 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
make concurrency checks more granular
cfeaace 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
Merge branch 'wlm/rule-matching' into wlm/action-filter
5c6c4b2
@kaushalmahi12
refactor as per lib changes
ab441dd 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12
Merge branch 'main' into wlm/action-filter
3055220
@kaushalmahi12
add CHANGELOG entry
abcb6de 
Signed-off-by: Kaushal Kumar <[email protected]>
@kaushalmahi12 kaushalmahi12 added the backport 2.x Backport to 2.x branch label Apr 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

❌ Gradle check result for abcb6de: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kaushalmahi12
apply spotless
16100b8 
Signed-off-by: Kaushal Kumar <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

❌ Gradle check result for 16100b8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kaushalmahi12
fix Unit test
8cdb1af 
Signed-off-by: Kaushal Kumar <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

❌ Gradle check result for 8cdb1af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr bugmakerrrrrr is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kaushalmahi12