[Backport 2.x] [Auto Suggest] Fix Grammar Changes #9313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* sql more field name tests Signed-off-by: Paul Sebastian <[email protected]> * undo search command change w/ updated logic, generalize rerun flag to work with any lang and any number of rules Signed-off-by: Paul Sebastian <[email protected]> * beginning of updating combined results properly Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #9120 created/updated * cleaner non-recursive system to go through rerunWithout rule list and a general nonspecific combine function Signed-off-by: Paul Sebastian <[email protected]> * revert qualified name grammar Signed-off-by: Paul Sebastian <[email protected]> * revert from and table source grammars Signed-off-by: Paul Sebastian <[email protected]> * fix ppl field name issue Signed-off-by: Paul Sebastian <[email protected]> * remove ppl agg func snippets and update ppl field name test Signed-off-by: Paul Sebastian <[email protected]> * leave a space for sql agg func Signed-off-by: Paul Sebastian <[email protected]> * ppl autocomplete more pref. rules test Signed-off-by: Paul Sebastian <[email protected]> * remove backticks from ppl field name to match for value completion Signed-off-by: Paul Sebastian <[email protected]> * add comment explaining result combination Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d227bc5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
sejli
approved these changes
Jan 31, 2025
sejli
approved these changes
Jan 31, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #9313 +/- ##
==========================================
+ Coverage 61.77% 61.79% +0.02%
==========================================
Files 3815 3815
Lines 91715 91843 +128
Branches 14513 14539 +26
==========================================
+ Hits 56653 56754 +101
+ Misses 31441 31438 -3
- Partials 3621 3651 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
approved these changes
Jan 31, 2025
|
Cypress tests are passing, it's currently failing on artifact uploads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d227bc5 from #9120.