[Backport 2.x] Add navControlsPrimaryHeaderRight slot to header #9250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add navControlNewPrimaryRight slot to header Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #9223 created/updated * Fix vertical align for header items Signed-off-by: Lin Wang <[email protected]> * Fix test coverage drop Signed-off-by: Lin Wang <[email protected]> * Fix failed UTs Signed-off-by: Lin Wang <[email protected]> * Fix bootstrap failed Signed-off-by: Lin Wang <[email protected]> * Update failed snapshots Signed-off-by: Lin Wang <[email protected]> * Remove left border Signed-off-by: Lin Wang <[email protected]> * Refactor with headerRight Signed-off-by: Lin Wang <[email protected]> * Renaming to primaryHeaderRight Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #9223 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8ae1c71) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #9250 +/- ##
=======================================
Coverage 61.12% 61.12%
=======================================
Files 3814 3814
Lines 91502 91508 +6
Branches 14450 14450
=======================================
+ Hits 55932 55938 +6
Misses 32011 32011
Partials 3559 3559
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jan 22, 2025
|
ciGroups 9 / 10 / 11 are known issues. |
ruanyl
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8ae1c71 from #9223.