Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Only support copy for query templates #9217

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[Backport 2.x] Only support copy for query templates #9217

wants to merge 1 commit into from
+58 −25

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a107509 from #8899.

@github-actions @opensearch-changeset-bot
Only support copy for query templates (#8899)
c3c0c0b 
* only support copy for query templates

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Changeset file for PR #8899 created/updated

* clear selected query on tab change; keep button disabled when query is not selected

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit a107509)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports seasoned-contributor labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jan 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.07%. Comparing base (51167bb) to head (c3c0c0b).

Files with missing lines Patch % Lines
...ui/saved_query_flyouts/open_saved_query_flyout.tsx 18.75% 10 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #9217      +/-   ##
==========================================
- Coverage   61.07%   61.07%   -0.01%     
==========================================
  Files        3813     3813              
  Lines       91454    91461       +7     
  Branches    14439    14441       +2     
==========================================
+ Hits        55852    55856       +4     
- Misses      32058    32060       +2     
- Partials     3544     3545       +1
Flag Coverage Δ
Linux_1 29.14% <ø> (ø)
Linux_2 56.59% <ø> (ø)
Linux_3 37.94% <18.75%> (-0.01%) ⬇️
Linux_4 29.18% <ø> (+<0.01%) ⬆️
Windows_1 29.15% <ø> (ø)
Windows_2 56.54% <ø> (ø)
Windows_3 37.94% <18.75%> (-0.01%) ⬇️
Windows_4 29.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbyhu2000 @ananzh