Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading opensearch client to 3.x #9139

Conversation

nhtruong
Copy link

@nhtruong nhtruong commented Dec 31, 2024

Description

Upgrading the OpenSearch Client dependency from 2.x to 3.x

Changelog

  • skip

(This change does not affect the end user of OSD)

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@nhtruong
Copy link
Author

Currently running yarn osd bootstrap will result in

ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 2: /Users/theotr/.yarn/bin/yarn.js run osd:bootstrap
      error Command failed with exit code 2.
      $ ../../scripts/use_node ../../scripts/remove.js target && tsc
      Deleted files and directories:
         
      src/cli.ts(42,32): error TS2307: Cannot find module '@osd/test' or its corresponding type declarations.
      info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
          at makeError (/Users/theotr/WebstormProjects/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:27525:11)
          at handlePromise (/Users/theotr/WebstormProjects/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:26461:26)
          at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
          at async /Users/theotr/WebstormProjects/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:9283:11
          at async scheduleItem (/Users/theotr/WebstormProjects/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:11336:9)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

even though @osd/test is specified in relevant package.json files

Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (5f91e37) to head (23fe787).
Report is 133 commits behind head on feature/node-2x.

Files with missing lines Patch % Lines
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/node-2x    #9139      +/-   ##
===================================================
- Coverage            60.91%   60.87%   -0.05%     
===================================================
  Files                 3808     3808              
  Lines                91196    91196              
  Branches             14400    14400              
===================================================
- Hits                 55556    55515      -41     
- Misses               32085    32123      +38     
- Partials              3555     3558       +3     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_4 ?
Windows_1 29.01% <ø> (-0.02%) ⬇️
Windows_2 56.34% <50.00%> (ø)
Windows_3 38.01% <ø> (ø)
Windows_4 29.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla changed the base branch from main to feature/node-2x March 2, 2025 05:03
Copy link
Contributor

github-actions bot commented Mar 2, 2025

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@kavilla
Copy link
Member

kavilla commented Mar 2, 2025

hey @nhtruong thanks for opening and handling the changes. i will target this towarrds this feature branch im working in that might need these changes. we can reopen this later if issues come from that.

@kavilla kavilla merged commit dcd6dc1 into opensearch-project:feature/node-2x Mar 2, 2025
9 of 64 checks passed
@kavilla
Copy link
Member

kavilla commented Mar 2, 2025

we should prolly reopen this. do we have a map of the APIs of the new expected APIs to previous api

kavilla pushed a commit that referenced this pull request Mar 7, 2025
kavilla pushed a commit that referenced this pull request Mar 14, 2025
kavilla pushed a commit that referenced this pull request Mar 18, 2025
kavilla pushed a commit that referenced this pull request Mar 18, 2025
kavilla added a commit that referenced this pull request Mar 20, 2025
Signed-off-by: Kawika Avilla <[email protected]>

Upgrade APM node

Signed-off-by: Kawika Avilla <[email protected]>

build with plugins workflow

Signed-off-by: Kawika Avilla <[email protected]>

add on push

Signed-off-by: Kawika Avilla <[email protected]>

plugins

Signed-off-by: Kawika Avilla <[email protected]>

dont run on image

Signed-off-by: Kawika Avilla <[email protected]>

just use node for plugin_helpers

Signed-off-by: Kawika Avilla <[email protected]>

unzip

Signed-off-by: Kawika Avilla <[email protected]>

unzip and then untar

Signed-off-by: Kawika Avilla <[email protected]>

create directory

Signed-off-by: Kawika Avilla <[email protected]>

updates

Signed-off-by: Kawika Avilla <[email protected]>

pwd

Signed-off-by: Kawika Avilla <[email protected]>

resolve to newer browserify rsa to avoid deprecation warning,

Signed-off-by: Kawika Avilla <[email protected]>

ensure encoding on filesync and also no hyphen for utf8

Signed-off-by: Kawika Avilla <[email protected]>

handle node issues

Signed-off-by: Kawika Avilla <[email protected]>

 build osd-pm

Signed-off-by: Kawika Avilla <[email protected]>

to string utf8

Signed-off-by: Kawika Avilla <[email protected]>

tostring utf8

Signed-off-by: Kawika Avilla <[email protected]>

Upgrading `opensearch` client to 3.x (#9139)

update dependencies

Signed-off-by: Kawika Avilla <[email protected]>

 dont expect error

Signed-off-by: Kawika Avilla <[email protected]>

ignore hapi

Signed-off-by: Kawika Avilla <[email protected]>

 restore polyfill after slight downgrade of typescript

Signed-off-by: Kawika Avilla <[email protected]>

fix tests

Signed-off-by: Kawika Avilla <[email protected]>

fix yarn lock file

Signed-off-by: Kawika Avilla <[email protected]>

update jest

Signed-off-by: Kawika Avilla <[email protected]>

remove ts jest and add module resolver

Signed-off-by: Kawika Avilla <[email protected]>

restore tests

Signed-off-by: Kawika Avilla <[email protected]>

skip test for now

Signed-off-by: Kawika Avilla <[email protected]>

fix caniuse

Signed-off-by: Kawika Avilla <[email protected]>

fix lock file

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Mar 20, 2025
Signed-off-by: Kawika Avilla <[email protected]>

Upgrade APM node

Signed-off-by: Kawika Avilla <[email protected]>

build with plugins workflow

Signed-off-by: Kawika Avilla <[email protected]>

add on push

Signed-off-by: Kawika Avilla <[email protected]>

plugins

Signed-off-by: Kawika Avilla <[email protected]>

dont run on image

Signed-off-by: Kawika Avilla <[email protected]>

just use node for plugin_helpers

Signed-off-by: Kawika Avilla <[email protected]>

unzip

Signed-off-by: Kawika Avilla <[email protected]>

unzip and then untar

Signed-off-by: Kawika Avilla <[email protected]>

create directory

Signed-off-by: Kawika Avilla <[email protected]>

updates

Signed-off-by: Kawika Avilla <[email protected]>

pwd

Signed-off-by: Kawika Avilla <[email protected]>

resolve to newer browserify rsa to avoid deprecation warning,

Signed-off-by: Kawika Avilla <[email protected]>

ensure encoding on filesync and also no hyphen for utf8

Signed-off-by: Kawika Avilla <[email protected]>

handle node issues

Signed-off-by: Kawika Avilla <[email protected]>

 build osd-pm

Signed-off-by: Kawika Avilla <[email protected]>

to string utf8

Signed-off-by: Kawika Avilla <[email protected]>

tostring utf8

Signed-off-by: Kawika Avilla <[email protected]>

Upgrading `opensearch` client to 3.x (#9139)

update dependencies

Signed-off-by: Kawika Avilla <[email protected]>

 dont expect error

Signed-off-by: Kawika Avilla <[email protected]>

ignore hapi

Signed-off-by: Kawika Avilla <[email protected]>

 restore polyfill after slight downgrade of typescript

Signed-off-by: Kawika Avilla <[email protected]>

fix tests

Signed-off-by: Kawika Avilla <[email protected]>

fix yarn lock file

Signed-off-by: Kawika Avilla <[email protected]>

update jest

Signed-off-by: Kawika Avilla <[email protected]>

remove ts jest and add module resolver

Signed-off-by: Kawika Avilla <[email protected]>

restore tests

Signed-off-by: Kawika Avilla <[email protected]>

skip test for now

Signed-off-by: Kawika Avilla <[email protected]>

fix caniuse

Signed-off-by: Kawika Avilla <[email protected]>

fix lock file

Signed-off-by: Kawika Avilla <[email protected]>

update workflow to run faster

Signed-off-by: Kawika Avilla <[email protected]>

skip test per suggestion

Signed-off-by: Kawika Avilla <[email protected]>

 some optimizations

Signed-off-by: Kawika Avilla <[email protected]>

restore chromium

Signed-off-by: Kawika Avilla <[email protected]>

fix regex

Signed-off-by: Kawika Avilla <[email protected]>

set limits for heap

Signed-off-by: Kawika Avilla <[email protected]>

bump types and cypress

Signed-off-by: Kawika Avilla <[email protected]>

bump semi space size

Signed-off-by: Kawika Avilla <[email protected]>

revert node types bump

Signed-off-by: Kawika Avilla <[email protected]>

update lock file and cypress workflow

Signed-off-by: Kawika Avilla <[email protected]>

wait until visible

Signed-off-by: Kawika Avilla <[email protected]>

split it out for 15 as well

Signed-off-by: Kawika Avilla <[email protected]>

add a wait

Signed-off-by: Kawika Avilla <[email protected]>

escape and make wait a command

Signed-off-by: Kawika Avilla <[email protected]>

set max semi space as well

Signed-off-by: Kawika Avilla <[email protected]>

skip problematic tests

Signed-off-by: Kawika Avilla <[email protected]>

skip recents

Signed-off-by: Kawika Avilla <[email protected]>

cypress string update and some clean up

Signed-off-by: Kawika Avilla <[email protected]>

clean up build plugins workflow

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Mar 20, 2025
Signed-off-by: Kawika Avilla <[email protected]>

Upgrade APM node

Signed-off-by: Kawika Avilla <[email protected]>

build with plugins workflow

Signed-off-by: Kawika Avilla <[email protected]>

add on push

Signed-off-by: Kawika Avilla <[email protected]>

plugins

Signed-off-by: Kawika Avilla <[email protected]>

dont run on image

Signed-off-by: Kawika Avilla <[email protected]>

just use node for plugin_helpers

Signed-off-by: Kawika Avilla <[email protected]>

unzip

Signed-off-by: Kawika Avilla <[email protected]>

unzip and then untar

Signed-off-by: Kawika Avilla <[email protected]>

create directory

Signed-off-by: Kawika Avilla <[email protected]>

updates

Signed-off-by: Kawika Avilla <[email protected]>

pwd

Signed-off-by: Kawika Avilla <[email protected]>

resolve to newer browserify rsa to avoid deprecation warning,

Signed-off-by: Kawika Avilla <[email protected]>

ensure encoding on filesync and also no hyphen for utf8

Signed-off-by: Kawika Avilla <[email protected]>

handle node issues

Signed-off-by: Kawika Avilla <[email protected]>

 build osd-pm

Signed-off-by: Kawika Avilla <[email protected]>

to string utf8

Signed-off-by: Kawika Avilla <[email protected]>

tostring utf8

Signed-off-by: Kawika Avilla <[email protected]>

Upgrading `opensearch` client to 3.x (#9139)

update dependencies

Signed-off-by: Kawika Avilla <[email protected]>

 dont expect error

Signed-off-by: Kawika Avilla <[email protected]>

ignore hapi

Signed-off-by: Kawika Avilla <[email protected]>

 restore polyfill after slight downgrade of typescript

Signed-off-by: Kawika Avilla <[email protected]>

fix tests

Signed-off-by: Kawika Avilla <[email protected]>

fix yarn lock file

Signed-off-by: Kawika Avilla <[email protected]>

update jest

Signed-off-by: Kawika Avilla <[email protected]>

remove ts jest and add module resolver

Signed-off-by: Kawika Avilla <[email protected]>

restore tests

Signed-off-by: Kawika Avilla <[email protected]>

skip test for now

Signed-off-by: Kawika Avilla <[email protected]>

fix caniuse

Signed-off-by: Kawika Avilla <[email protected]>

fix lock file

Signed-off-by: Kawika Avilla <[email protected]>

update workflow to run faster

Signed-off-by: Kawika Avilla <[email protected]>

skip test per suggestion

Signed-off-by: Kawika Avilla <[email protected]>

 some optimizations

Signed-off-by: Kawika Avilla <[email protected]>

restore chromium

Signed-off-by: Kawika Avilla <[email protected]>

fix regex

Signed-off-by: Kawika Avilla <[email protected]>

set limits for heap

Signed-off-by: Kawika Avilla <[email protected]>

bump types and cypress

Signed-off-by: Kawika Avilla <[email protected]>

bump semi space size

Signed-off-by: Kawika Avilla <[email protected]>

revert node types bump

Signed-off-by: Kawika Avilla <[email protected]>

update lock file and cypress workflow

Signed-off-by: Kawika Avilla <[email protected]>

wait until visible

Signed-off-by: Kawika Avilla <[email protected]>

split it out for 15 as well

Signed-off-by: Kawika Avilla <[email protected]>

add a wait

Signed-off-by: Kawika Avilla <[email protected]>

escape and make wait a command

Signed-off-by: Kawika Avilla <[email protected]>

set max semi space as well

Signed-off-by: Kawika Avilla <[email protected]>

skip problematic tests

Signed-off-by: Kawika Avilla <[email protected]>

skip recents

Signed-off-by: Kawika Avilla <[email protected]>

cypress string update and some clean up

Signed-off-by: Kawika Avilla <[email protected]>

clean up build plugins workflow

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants